On Fri, Feb 25, 2011 at 12:01 PM, John Hunter <jdh2...@gmail.com> wrote: > I just want to throw out there that in the migration to github, we > never officially said we were going to switch the development process. > In fact, we said the opposite. After the migration, Jarrod suggested > the pull request workflow as espoused in gitwash, and I am happy to > experiment with it, but only to the extent that "it works", ie we are > getting fast enough code reviews and pull requests closed that > development is slowed significantly. In our experience on sf, we > weren't doing a good job keeping up with submitted requests by > non-developers on the trackers, much less reviewing the core devs' > contributions. Let he who thinks they can keep up with MD and JJ step > forward...
One comment from the peanut gallery: what we've found in ipython is that the git pull request system does make the review process vastly more efficient. The tool is good enough that we've been reviewing things pretty quickly, and it does overall help the project's code quality quite a bit. It makes a big difference if doing a review has high overhead or if it's just a matter of clicking on a link, having all the information nicely presented there for you (conversation, files changed, highlighted diff), and being able to comment in 2 minutes. For simple things often my review amounts to 'good job, merge away but fix this little thing I commented on inline'. It takes me 2 minutes to do it, I manage to get in some feedback that improves the code before merge, and I don't even ever download the actual branch, since I do all the reviewing (for simple ones) just from the diffs on the github pages. Cheers, f ------------------------------------------------------------------------------ Free Software Download: Index, Search & Analyze Logs and other IT data in Real-Time with Splunk. Collect, index and harness all the fast moving IT data generated by your applications, servers and devices whether physical, virtual or in the cloud. Deliver compliance at lower cost and gain new business insights. http://p.sf.net/sfu/splunk-dev2dev _______________________________________________ Matplotlib-devel mailing list Matplotlib-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/matplotlib-devel
