On 11-08-08 03:48 PM, Christopher Brooks wrote: > Greg, > > So are some services broken when we have the period? Can you identify > them?
Not broken per-se, just not accessible in the same way. For example, /capture-admin/agents is accessible at capture-admin/agents.json or capture-admin/agents.xml, but not at /capture-admin/agents. I imagine some of the other ones have changed as well, but I don't know if anything is using them (yet). I think Markus' suggestion that we regularize the endpoints is a good one, especially since very little talks to this endpoint. I'm not sure that this is a good time for it, but we either fix this issue, fix the rest doc generation code, or release with broken rest docs. Of those options I think the first is probably the least likely to cause issues. G > Chris > > >> On 11-08-08 01:57 PM, Greg Logan wrote: >>> Hi Folks, >>> >>> I noticed and filed http://opencast.jira.com/browse/MH-8049 this >>> morning, and upon further investigation this appears to be caused >>> by the change committed as a proposed fix for >>> http://opencast.jira.com/browse/MH-7816. The endpoint MH-8049 >>> requires looked like /capture-admin/agents/agents.xml (or .json, I >>> don't remember which). The changeset committed for MH-7816 removes >>> the period from the endpoint, which changes the endpoint >>> to /capture-admin/agents/agentsxml. >> >> Bah, it adds it rather than removes. The endpoint now *requires* the >> period and type (json/xml), something I was trying to avoid when >> writing the optional parameters. This is also why the admin UI >> breaks: it's calling for capture-admin/agents. >> >> G >> >>> I don't think this is the right way to go about this, and changing >>> REST endpoints this late in the 1.2 release cycle is an especially >>> bad idea. Since these periods are used extensively in other >>> services we should instead we should be focusing on making the REST >>> doc generation code understand and process these optional >>> parameters. >>> >>> Thoughts? I think reverting that changeset is the best option at >>> this point... >>> G >>> >>> >>> >>> >>> _______________________________________________ >>> Matterhorn mailing list >>> [email protected] >>> http://lists.opencastproject.org/mailman/listinfo/matterhorn >>> >>> >>> To unsubscribe please email >>> [email protected] >>> _______________________________________________ >> >> > > >
signature.asc
Description: OpenPGP digital signature
_______________________________________________ Matterhorn mailing list [email protected] http://lists.opencastproject.org/mailman/listinfo/matterhorn To unsubscribe please email [email protected] _______________________________________________
