On 11-08-08 03:25 PM, Markus Moormann wrote: > Hi > > Am 08.08.2011 22:16, schrieb Greg Logan: >> On 11-08-08 01:57 PM, Greg Logan wrote: >>> Hi Folks, >>> >>> I noticed and filed http://opencast.jira.com/browse/MH-8049 this >>> morning, and upon further investigation this appears to be caused by the >>> change committed as a proposed fix for >>> http://opencast.jira.com/browse/MH-7816. The endpoint MH-8049 requires >>> looked like /capture-admin/agents/agents.xml (or .json, I don't remember >>> which). The changeset committed for MH-7816 removes the period from the >>> endpoint, which changes the endpoint to /capture-admin/agents/agentsxml. > I didn't intend to break something neither did I know that this is an > optional parameter. The changes were the only chance I saw to fix the > issue. This ticket was open since 1st June and is declared as RB, so I > fixed it along with http://opencast.jira.com/browse/MH-7945. Further
Ah, fair enough. This was not well documented, my fault. > more I'm used to using Endpoints with .json or .xml from the UI > perspective and I think we you stick with this standard. If the UI is > calling capture-admin/agents I can fix this in the UI tomorrow and see > whether there are some more of this issues. The other option is to > revert and find another solution for this but we should not release with > broken docs. I agree, but I don't know that this is the time. I don't think the other changes will break anything, so maybe we should just change the UI. G > Regards >> Bah, it adds it rather than removes. The endpoint now *requires* the >> period and type (json/xml), something I was trying to avoid when writing >> the optional parameters. This is also why the admin UI breaks: it's >> calling for capture-admin/agents. >> >> G >> >>> I don't think this is the right way to go about this, and changing REST >>> endpoints this late in the 1.2 release cycle is an especially bad idea. >>> Since these periods are used extensively in other services we should >>> instead we should be focusing on making the REST doc generation code >>> understand and process these optional parameters. >>> >>> Thoughts? I think reverting that changeset is the best option at this >>> point... >>> G >>> >>> >>> >>> >>> _______________________________________________ >>> Matterhorn mailing list >>> [email protected] >>> http://lists.opencastproject.org/mailman/listinfo/matterhorn >>> >>> >>> To unsubscribe please email >>> [email protected] >>> _______________________________________________ >> >> >> >> _______________________________________________ >> Matterhorn mailing list >> [email protected] >> http://lists.opencastproject.org/mailman/listinfo/matterhorn >> >> >> To unsubscribe please email >> [email protected] >> _______________________________________________ > > > _______________________________________________ > Matterhorn mailing list > [email protected] > http://lists.opencastproject.org/mailman/listinfo/matterhorn > > > To unsubscribe please email > [email protected] > _______________________________________________
signature.asc
Description: OpenPGP digital signature
_______________________________________________ Matterhorn mailing list [email protected] http://lists.opencastproject.org/mailman/listinfo/matterhorn To unsubscribe please email [email protected] _______________________________________________
