[
http://opencast.jira.com/browse/MH-8052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=27732#comment-27732
]
Greg Logan edited comment on MH-8052 at 8/9/11 10:15 PM:
---------------------------------------------------------
The directory is successfully created, and indeed has a bunch of files in it so
I don't quite get what's going on.
Relevant code:
if (!collectionDir.exists()) {
try {
FileUtils.forceMkdir(collectionDir);
logger.info("created collection directory " + collectionId);
} catch (IOException e) {
throw new IllegalStateException("can not create collection directory" +
collectionDir);
}
}
The only thing I can think of is that collectionDir does not exist for the
first check, but another thread creates it in the meantime.
FileUtils.forceMkdir throws an IOException if the directory already exists, or
if it can't be created. Maybe we should wrap the throw statement in another
check to make sure the directory does not exist?
Edit: for clarity.
was (Author: greg_logan):
The directory is successfully created, and indeed has a bunch of files in
it so I don't quite get what's going on.
Relevant code:
if (!collectionDir.exists()) {
try {
FileUtils.forceMkdir(collectionDir);
logger.info("created collection directory " + collectionId);
} catch (IOException e) {
throw new IllegalStateException("can not create collection directory" +
collectionDir);
}
}
The only thing I can think of is the first if collectionDir does not exist, but
another thread creates it in the meantime. FileUtils.forceMkdir throws an
IOException if the directory already exists, or if it can't be created. Maybe
we should wrap the throw statement in another check to make sure the directory
does not exist?
> Race Condition in WorkingFileRepository causes some processing runs to fail
> ---------------------------------------------------------------------------
>
> Key: MH-8052
> URL: http://opencast.jira.com/browse/MH-8052
> Project: Matterhorn Project
> Issue Type: Bug
> Components: Architecture & Services
> Affects Versions: 1.2, Trunk
> Reporter: Greg Logan
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
_______________________________________________
Matterhorn mailing list
[email protected]
http://lists.opencastproject.org/mailman/listinfo/matterhorn
To unsubscribe please email
[email protected]
_______________________________________________
