On 11-08-25 01:15 PM, David Horwitz wrote: > Interestingly I've been building trunk on a Jenkins instance and it > doesn't show any test failures.: > > http://arabica.cet.uct.ac.za:8080/job/Matterhorn/
That URL is hidden behind a login :) > Neither does a local build (I'm a newby so may have missed if these > tests are disabled by default) Unless you reinstall the 3rd party tools via the script you won't notice. It's only when ffmpeg is updated that its command line arguments change, which breaks the java code. For the committers, I haven't reverted the change because I can't seem to get ffmpeg to compile when I roll back the last few days of patches. I don't have a ton of time to debug this, so I may end up just leaving things as they are until Matjaz/Ruediger fix things unfortunately... G > > BTW if it would be useful to the community to make the Jenkins build we > have more visible or send alerts to developers who break the build/to > twitter or where ever please let me know. > > Regards > > David > > On 08/25/2011 06:31 PM, Tobias Wunden wrote: >> Greg, >> >> I haven't looked at trunk since that change was committed. If the >> tests *are* broken, then the change should indeed be rolled back. A >> broken build is not acceptable, and letting it pass this time means >> letting go of stable builds in general, which I don't think is an >> option for us. >> >> Tobias >> >> On 25.08.2011, at 18:06, Greg Logan wrote: >> >>> Hi folks, >>> >>> The recent update of ffmpeg to 0.8.2 in trunk has broken the unit tests >>> in matterhorn-composer-ffmpeg. I assume this has also broken the >>> encoding pipeline, but since it won't build without disabling the unit >>> tests I haven't bothered to try. >>> >>> This is really disappointing to me, especially when we decided to keep >>> our old version of ffmpeg specifically because _we knew upgrading might >>> cause problems_. It's doubly disappointing because the change was >>> committed and obviously has gone completely untested. I can understand >>> missing the integration tests (I've done that a few times), but not even >>> testing the compilation, much less the functionality, of the composer >>> module against the new version is worrying. >>> >>> I #propose we revert these changes until they are properly tested. >>> >>> G >> _______________________________________________ >> Matterhorn mailing list >> [email protected] >> http://lists.opencastproject.org/mailman/listinfo/matterhorn >> >> >> To unsubscribe please email >> [email protected] >> _______________________________________________ > _______________________________________________ > Matterhorn mailing list > [email protected] > http://lists.opencastproject.org/mailman/listinfo/matterhorn > > > To unsubscribe please email > [email protected] > _______________________________________________
signature.asc
Description: OpenPGP digital signature
_______________________________________________ Matterhorn mailing list [email protected] http://lists.opencastproject.org/mailman/listinfo/matterhorn To unsubscribe please email [email protected] _______________________________________________
