Hi,
I'm sorry for the uncomplete commit, I missed to commit of the encoding
properties and the properties used by the unit test. Sorry!
The changes have not been untested and I have checked that ffmpeg
version works even with 1.1.x branch if the encoding profiles are
updated (I don't intend to backport these changes to 1.1.x, although we
are using them with this release too).
I did a fresh checkout to make sure that I did not miss some of my
changes again and build it without errors, but the integration tests
fail for me, but not in encoding: http://opencast.jira.com/browse/MH-8090
I proposed a while ago to upgrade the ffmpeg version for 1.2, and that
was refused. But for our current developments (branding and HTML5 video)
this is not an optional decision anymore, so I don't feel the need to
discuss if we want to update. If the others think that updating ffmpeg
is too dangerous our only option would be to continue Osnabrücks further
developments in a separate branch.
Regards
Rüdiger
Am 26.08.2011 04:18, schrieb Josh Holtzman:
Greg,
I wasn't aware that we'd upgraded ffmpeg in trunk. I actually asked on list [1] whether
we should upgrade a few weeks ago, and the response was "no", so I'm wondering
who and why this was slipped in.
It turns out, I've been building locally against ffmpeg trunk anyhow. The only change we need to
make is to fix ffmpeg's former command line typo from "inofficial" to
"unofficial" in our encoding profiles.
Does that do the trick for your ffmpeg build?
Josh
On Aug 25, 2011, at 9:31 AM, Tobias Wunden wrote:
Greg,
I haven't looked at trunk since that change was committed. If the tests *are*
broken, then the change should indeed be rolled back. A broken build is not
acceptable, and letting it pass this time means letting go of stable builds in
general, which I don't think is an option for us.
Tobias
On 25.08.2011, at 18:06, Greg Logan wrote:
Hi folks,
The recent update of ffmpeg to 0.8.2 in trunk has broken the unit tests
in matterhorn-composer-ffmpeg. I assume this has also broken the
encoding pipeline, but since it won't build without disabling the unit
tests I haven't bothered to try.
This is really disappointing to me, especially when we decided to keep
our old version of ffmpeg specifically because _we knew upgrading might
cause problems_. It's doubly disappointing because the change was
committed and obviously has gone completely untested. I can understand
missing the integration tests (I've done that a few times), but not even
testing the compilation, much less the functionality, of the composer
module against the new version is worrying.
I #propose we revert these changes until they are properly tested.
G
_______________________________________________
Matterhorn mailing list
[email protected]
http://lists.opencastproject.org/mailman/listinfo/matterhorn
To unsubscribe please email
[email protected]
_______________________________________________
_______________________________________________
Matterhorn mailing list
[email protected]
http://lists.opencastproject.org/mailman/listinfo/matterhorn
To unsubscribe please email
[email protected]
_______________________________________________
--
________________________________________________
Rüdiger Rolf, M.A.
Universität Osnabrück - Zentrum virtUOS
Heger-Tor-Wall 12, 49069 Osnabrück
Telefon: (0541) 969-6511 - Fax: (0541) 969-16511
E-Mail: [email protected]
Internet: www.virtuos.uni-osnabrueck.de
_______________________________________________
Matterhorn mailing list
[email protected]
http://lists.opencastproject.org/mailman/listinfo/matterhorn
To unsubscribe please email
[email protected]
_______________________________________________
