[
http://opencast.jira.com/browse/MH-8081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=28336#comment-28336
]
Rubén Pérez Vázquez commented on MH-8081:
-----------------------------------------
Good fix: so currently NO service is marked as overloaded, even though it is,
making the whole purpose of the heartbeat useless. Brilliant.
Wouldn't it be much better if ALL services were checked, so that the ones
considered online, but overloaded, were marked as so, AND those considered
overloaded which are not anymore are marked as online again? It's as easy as
modifying the current if-else pattern to take this into account. In pseudocode:
for service in SERVICES {
available = IS_AVAILABLE(service);
if available {
// The service is currently available
if NOT service.available {
// The service is back again
service.available = TRUE;
service.unavail_counter = 0;
}
} else {
// The service is NOT currently available
service.available = FALSE;
service.unavail_counter += 1;
if service.unavail_counter >= MAX_UNAVAIL {
SERVICES.delete(service);
}
}
}
Any reason why this cannot be made? Because if we keep "patching" instead of
"fixing" in those places where it can be done, we will end up with a bunch of
patches that, eventually, won't work at all. And I believe this one is pretty
straightforward...
> Distributed servers go offline in service registry after heatbeat check
> -----------------------------------------------------------------------
>
> Key: MH-8081
> URL: http://opencast.jira.com/browse/MH-8081
> Project: Matterhorn Project
> Issue Type: Bug
> Components: Administrative Tools
> Affects Versions: 1.2
> Reporter: Adam McKenzie
> Assignee: Greg Logan
> Priority: Release Blocker
> Fix For: 1.2.1
>
> Attachments: opencast.log, serviceRegistryPatch1.2
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
http://opencast.jira.com/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
_______________________________________________
Matterhorn mailing list
[email protected]
http://lists.opencastproject.org/mailman/listinfo/matterhorn
To unsubscribe please email
[email protected]
_______________________________________________
