>>>>> "Gerard" == Gerard Gorman <[EMAIL PROTECTED]> writes:
Gerard> Hi Prabhu MayaVi v1.x, StructuredPointsProbe.py was giving
Gerard> me trouble when I was redefining dimensions. It wasn't
Gerard> updating properly unless I hit enter twice, making things
Gerard> difficult for scripting. The problem boiled down to
Gerard> vtkProbeFilter requiring a call to UpdateWholeExtent.
Gerard> The filter also now allows you to specify the spacing
Gerard> instead of the dimensions. This is handy if you have to
Gerard> extract data at a specific resolution. Some cosmetic
Gerard> changes were also made to make the style more consistent
Gerard> with the rest of the code.
Many thanks for the code. Here are some comments:
1. You have mixed tabs and spaces. Please "untabify" the source
before checking it in. In general it is a good idea to use
tabnanny.py to figure out if the sources are clean of tabs.
2. There are a few places where I disable the warnings and re-enable
them. You have removed those. Can you please add those back in.
3. Please verify that the save/load features work properly.
4. I noticed a print statement which can be removed.
Please also test it so it works correctly. I hardly use the filter so
you probably can test it better.
Gerard> Let me know if the attached gets your blessing for a
Gerard> commit. Now, I really must get around to checking out v2.0
If the above issues are addressed I think you can go ahead and check
it in. Thanks!
Yes, please have a go at v2.0 and send in your comments.
cheers,
prabhu
-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
MayaVi-users mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/mayavi-users
