Matthias Mullie has submitted this change and it was merged. Change subject: Maintenance for ArticleFeedbackv5. ......................................................................
Maintenance for ArticleFeedbackv5. * Remove unused local variables/assignments. * Replace deprecated methods (or mark @todo). * Fix unescaped output in SpecialArticleFeedbackv5.php. * Sprinkle missing semi-colons over JavaScript. * Mark duplicate array key as FIXME. * Mark use of reserved word as possible FIXME. * Change reserved word short used as variable name. * Fixed auto-unhiding upon unflagging feedback. * Removed aft5_debug() global JS function. Change-Id: Ie0f31289687bc49606bbaae19f34018d5741bf4a --- M ArticleFeedbackv5.flagging.php M ArticleFeedbackv5.hooks.php M SpecialArticleFeedbackv5.php M api/ApiArticleFeedbackv5.php M api/ApiArticleFeedbackv5Utils.php M api/ApiFlagFeedbackArticleFeedbackv5.php M api/ApiViewFeedbackArticleFeedbackv5.php M api/ApiViewRatingsArticleFeedbackv5.php M maintenance/refreshLastActivity.php M modules/ext.articleFeedbackv5/ext.articleFeedbackv5.dashboard.js M modules/ext.articleFeedbackv5/ext.articleFeedbackv5.startup.js M modules/jquery.articleFeedbackv5/jquery.articleFeedbackv5.js M modules/jquery.articleFeedbackv5/jquery.articleFeedbackv5.special.js M modules/jquery.articleFeedbackv5/jquery.articleFeedbackv5.track.js 14 files changed, 56 insertions(+), 110 deletions(-) Approvals: Matthias Mullie: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/21479 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie0f31289687bc49606bbaae19f34018d5741bf4a Gerrit-PatchSet: 3 Gerrit-Project: mediawiki/extensions/ArticleFeedbackv5 Gerrit-Branch: master Gerrit-Owner: Siebrand <[email protected]> Gerrit-Reviewer: Matthias Mullie <[email protected]> Gerrit-Reviewer: Siebrand <[email protected]> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
