EBernhardson has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/99164


Change subject: Disable potential external loading in ParsoidUtils::createDOM
......................................................................

Disable potential external loading in ParsoidUtils::createDOM

Change-Id: I810fedc4081d2a123a784d3ab6db8dd314cbc42f
---
M includes/ParsoidUtils.php
1 file changed, 3 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Flow 
refs/changes/64/99164/1

diff --git a/includes/ParsoidUtils.php b/includes/ParsoidUtils.php
index 16b9f1b..9e2bea9 100644
--- a/includes/ParsoidUtils.php
+++ b/includes/ParsoidUtils.php
@@ -177,6 +177,9 @@
        public static function createDOM( $content, $ignoreErrorCodes = array( 
801 ) ) {
                $dom = new \DOMDocument();
 
+               // Otherwise the parser may attempt to load the dtd from an 
external source
+               $dom->resolveExternals = false;
+
                // don't output warnings
                $useErrors = libxml_use_internal_errors( true );
 

-- 
To view, visit https://gerrit.wikimedia.org/r/99164
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I810fedc4081d2a123a784d3ab6db8dd314cbc42f
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Flow
Gerrit-Branch: master
Gerrit-Owner: EBernhardson <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to