jenkins-bot has submitted this change and it was merged.
Change subject: Add trivial tests for claimview, make them pass
......................................................................
Add trivial tests for claimview, make them pass
Change-Id: Ie70495488a185f5a47b50fe865fcb85ea5be6fe8
---
M lib/WikibaseLib.hooks.php
M lib/resources/jquery.wikibase/jquery.wikibase.claimview.js
A lib/tests/qunit/jquery.wikibase/jquery.wikibase.claimview.tests.js
3 files changed, 45 insertions(+), 1 deletion(-)
Approvals:
Addshore: Verified; Looks good to me, approved
jenkins-bot: Verified
diff --git a/lib/WikibaseLib.hooks.php b/lib/WikibaseLib.hooks.php
index 72f46ec..586473c 100644
--- a/lib/WikibaseLib.hooks.php
+++ b/lib/WikibaseLib.hooks.php
@@ -151,6 +151,15 @@
),
);
+ $testModules['qunit']['jquery.wikibase.claimview.tests'] =
$moduleBase + array(
+ 'scripts' => array(
+
'tests/qunit/jquery.wikibase/jquery.wikibase.claimview.tests.js',
+ ),
+ 'dependencies' => array(
+ 'jquery.wikibase.claimview'
+ ),
+ );
+
$testModules['qunit']['jquery.wikibase.listview.tests'] =
$moduleBase + array(
'scripts' => array(
'tests/qunit/jquery.wikibase/jquery.wikibase.listview.tests.js',
diff --git a/lib/resources/jquery.wikibase/jquery.wikibase.claimview.js
b/lib/resources/jquery.wikibase/jquery.wikibase.claimview.js
index 5119587..1822799 100644
--- a/lib/resources/jquery.wikibase/jquery.wikibase.claimview.js
+++ b/lib/resources/jquery.wikibase/jquery.wikibase.claimview.js
@@ -80,7 +80,7 @@
],
templateShortCuts: {
'$mainSnak': '.wb-claim-mainsnak',
- '$qualifiers': '.wb-statement-qualifiers'
+ '$qualifiers': '.wb-claim-qualifiers'
},
value: null,
predefined: {
diff --git a/lib/tests/qunit/jquery.wikibase/jquery.wikibase.claimview.tests.js
b/lib/tests/qunit/jquery.wikibase/jquery.wikibase.claimview.tests.js
new file mode 100644
index 0000000..c028dcb
--- /dev/null
+++ b/lib/tests/qunit/jquery.wikibase/jquery.wikibase.claimview.tests.js
@@ -0,0 +1,35 @@
+/**
+ * @licence GNU GPL v2+
+ * @author Adrian Lang < [email protected] >
+ */
+( function( $, mw, wb ) {
+ 'use strict';
+
+ function createClaimview( value ) {
+ var options = { value: value || null };
+
+ return mw.template('wb-claim', 'new', 'wb-last', '', '')
+ .addClass( 'test_claimview' )
+ .claimview( options );
+ }
+
+ QUnit.module( 'jquery.wikibase.claimview',
window.QUnit.newWbEnvironment( {
+ } ) );
+
+ QUnit.test( 'Initialize and destroy', function( assert ) {
+ var $node = createClaimview(),
+ claimview = $node.data( 'claimview' );
+
+ assert.ok(
+ claimview !== undefined,
+ 'Initialized claimview widget.'
+ );
+
+ claimview.destroy();
+
+ assert.ok(
+ $node.data( 'listview' ) === undefined,
+ 'Destroyed listview.'
+ );
+ } );
+} )( jQuery, mediaWiki, wikibase );
--
To view, visit https://gerrit.wikimedia.org/r/107352
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie70495488a185f5a47b50fe865fcb85ea5be6fe8
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Adrian Lang <[email protected]>
Gerrit-Reviewer: Addshore <[email protected]>
Gerrit-Reviewer: Henning Snater <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
