Milimetric has submitted this change and it was merged.
Change subject: Makes filtering better
......................................................................
Makes filtering better
Change-Id: I8299340dba3b38c3db5df5e19f243cea1ba31073
---
M wikimetrics/templates/cohorts.html
M wikimetrics/templates/report.html
2 files changed, 2 insertions(+), 2 deletions(-)
Approvals:
Milimetric: Verified; Looks good to me, approved
diff --git a/wikimetrics/templates/cohorts.html
b/wikimetrics/templates/cohorts.html
index 090282d..acf4834 100644
--- a/wikimetrics/templates/cohorts.html
+++ b/wikimetrics/templates/cohorts.html
@@ -7,7 +7,7 @@
<a class="btn btn-primary btn-large"
href="{{url_for('cohort_upload')}}">Upload Cohort</a>
- <input type="text" class="search-query" placeholder="type and press enter
to filter" data-bind="value: filter"/>
+ <input type="text" class="search-query" placeholder="type to filter"
data-bind="value: filter, valueUpdate:'afterkeydown'"/>
</div>
<hr/>
<div class="tabbable tabs-left">
diff --git a/wikimetrics/templates/report.html
b/wikimetrics/templates/report.html
index 3a924da..0617f6b 100644
--- a/wikimetrics/templates/report.html
+++ b/wikimetrics/templates/report.html
@@ -7,7 +7,7 @@
<div class="navbar-search pull-right">
<a href="{{url_for('cohort_upload')}}">upload a new cohort</a>
- <input type="text" class="search-query" placeholder="type and
press enter to filter" data-bind="value: filter"/>
+ <input type="text" class="search-query" placeholder="type to
filter" data-bind="value: filter, valueUpdate:'afterkeydown'"/>
</div>
</div>
<div class="cohorts">
--
To view, visit https://gerrit.wikimedia.org/r/108913
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8299340dba3b38c3db5df5e19f243cea1ba31073
Gerrit-PatchSet: 1
Gerrit-Project: analytics/wikimetrics
Gerrit-Branch: master
Gerrit-Owner: Milimetric <[email protected]>
Gerrit-Reviewer: Milimetric <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits