Yuvipanda has uploaded a new change for review. https://gerrit.wikimedia.org/r/113805
Change subject: Show a message when no items are present in History ...................................................................... Show a message when no items are present in History Change-Id: I7aa0f88de1beac0386a9a975e46c3973fa705934 --- M wikipedia/res/layout/activity_history.xml M wikipedia/res/values/strings.xml M wikipedia/src/main/java/org/wikipedia/history/HistoryActivity.java 3 files changed, 13 insertions(+), 3 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/apps/android/wikipedia refs/changes/05/113805/1 diff --git a/wikipedia/res/layout/activity_history.xml b/wikipedia/res/layout/activity_history.xml index f1edbbe..9604e4d 100644 --- a/wikipedia/res/layout/activity_history.xml +++ b/wikipedia/res/layout/activity_history.xml @@ -1,13 +1,19 @@ <?xml version="1.0" encoding="utf-8"?> -<LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"; - android:orientation="vertical" +<FrameLayout xmlns:android="http://schemas.android.com/apk/res/android"; android:layout_width="match_parent" android:layout_height="match_parent"> + <org.wikipedia.styledviews.StyledTextView + android:id="@+id/history_empty_message" + android:layout_width="match_parent" + android:layout_height="match_parent" + android:gravity="center" + android:text="@string/history_empty_message" + /> <ListView android:id="@+id/history_entry_list" android:layout_width="match_parent" android:layout_height="match_parent" /> -</LinearLayout> \ No newline at end of file +</FrameLayout> \ No newline at end of file diff --git a/wikipedia/res/values/strings.xml b/wikipedia/res/values/strings.xml index 26569ad..3b43133 100644 --- a/wikipedia/res/values/strings.xml +++ b/wikipedia/res/values/strings.xml @@ -80,4 +80,5 @@ <string name="nav_item_logout">Log out</string> <string name="logging_out_progress">Logging out...</string> <string name="saved_pages_empty_message">No saved pages.</string> + <string name="history_empty_message">Your history is empty.</string> </resources> diff --git a/wikipedia/src/main/java/org/wikipedia/history/HistoryActivity.java b/wikipedia/src/main/java/org/wikipedia/history/HistoryActivity.java index 184539c..43a990d 100644 --- a/wikipedia/src/main/java/org/wikipedia/history/HistoryActivity.java +++ b/wikipedia/src/main/java/org/wikipedia/history/HistoryActivity.java @@ -25,6 +25,7 @@ public class HistoryActivity extends ActionBarActivity implements LoaderManager.LoaderCallbacks<Cursor> { private ListView historyEntryList; + private View historyEmptyMessage; private HistoryEntryAdapter adapter; private WikipediaApp app; @@ -36,9 +37,11 @@ setContentView(R.layout.activity_history); historyEntryList = (ListView) findViewById(R.id.history_entry_list); + historyEmptyMessage = findViewById(R.id.history_empty_message); adapter = new HistoryEntryAdapter(this, null, true); historyEntryList.setAdapter(adapter); + historyEntryList.setEmptyView(historyEmptyMessage); historyEntryList.setOnItemClickListener(new AdapterView.OnItemClickListener() { @Override -- To view, visit https://gerrit.wikimedia.org/r/113805 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I7aa0f88de1beac0386a9a975e46c3973fa705934 Gerrit-PatchSet: 1 Gerrit-Project: apps/android/wikipedia Gerrit-Branch: master Gerrit-Owner: Yuvipanda <[email protected]> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
