jenkins-bot has submitted this change and it was merged.
Change subject: Remove unused js config variable
......................................................................
Remove unused js config variable
wbDataLangName is unused
Change-Id: I91bae010b6d6954c7d5e191c6caf8a6043207cc2
---
M repo/includes/EntityView.php
M repo/tests/phpunit/includes/EntityViewTest.php
2 files changed, 1 insertion(+), 3 deletions(-)
Approvals:
Tobias Gritschacher: Looks good to me, approved
WikidataJenkins: Verified
jenkins-bot: Verified
diff --git a/repo/includes/EntityView.php b/repo/includes/EntityView.php
index dd6118f..418ce84 100644
--- a/repo/includes/EntityView.php
+++ b/repo/includes/EntityView.php
@@ -650,8 +650,8 @@
$out->addJsConfigVars( 'wbUserCanEdit', $title->userCan(
'edit', $user, false ) ); //TODO: make this a per-entity info
$out->addJsConfigVars( 'wbIsEditView', $editableView );
//NOTE: page-wide property, independent of user permissions
+ // used by gadgets in wikidata
$out->addJsConfigVars( 'wbEntityType', $entity->getType() );
- $out->addJsConfigVars( 'wbDataLangName',
Utils::fetchLanguageName( $langCode ) );
// entity specific data
$out->addJsConfigVars( 'wbEntityId',
$this->getFormattedIdForEntity( $entity ) );
diff --git a/repo/tests/phpunit/includes/EntityViewTest.php
b/repo/tests/phpunit/includes/EntityViewTest.php
index 92b96d9..895aded 100644
--- a/repo/tests/phpunit/includes/EntityViewTest.php
+++ b/repo/tests/phpunit/includes/EntityViewTest.php
@@ -484,7 +484,6 @@
$argLists[] = array( $revision, $entityLoader, null,
$languageFallbackChain, 'fr', true, array(
'wbEntityType' => 'item',
- 'wbDataLangName' => 'français',
'wbEntityId' => 'Q27449',
'wbEntity' =>
'{"id":"Q27449","type":"item","labels":{"de":{"language":"de","value":"foo"},"fr":{"language":"de","value":"foo"}},"claims":{"P11":[{"id":"EntityViewTest$1","mainsnak":{"snaktype":"value","property":"P11","datavalue":{"value":{"entity-type":"item","numeric-id":27498},"type":"wikibase-entityid"}},"type":"claim"}]}}',
'wbUsedEntities' =>
'{"P11":{"content":{"id":"P11","type":"property"},"title":"property:P11"},"Q27498":{"content":{"id":"Q27498","type":"item","labels":{"fr":{"language":"de","value":"bar"}}},"title":"'
. $titleText . '"}}',
@@ -587,7 +586,6 @@
$argLists[] = array( $revision, $context,
$languageFallbackChain, true, array(
'wbEntityType' => 'item',
- 'wbDataLangName' => 'Nederlands',
'wbEntityId' => $entity->getId()->getSerialization(),
'wbEntity' => json_encode( $entityData ),
'wbUsedEntities' => json_encode( array(
--
To view, visit https://gerrit.wikimedia.org/r/113933
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I91bae010b6d6954c7d5e191c6caf8a6043207cc2
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Aude <[email protected]>
Gerrit-Reviewer: Adrian Lang <[email protected]>
Gerrit-Reviewer: Aude <[email protected]>
Gerrit-Reviewer: Fomafix
Gerrit-Reviewer: Henning Snater <[email protected]>
Gerrit-Reviewer: Hoo man <[email protected]>
Gerrit-Reviewer: Thiemo Mättig (WMDE) <[email protected]>
Gerrit-Reviewer: Tobias Gritschacher <[email protected]>
Gerrit-Reviewer: WikidataJenkins <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
