Tpt has uploaded a new change for review.
https://gerrit.wikimedia.org/r/114463
Change subject: Improves JavaScript code quality
......................................................................
Improves JavaScript code quality
Change-Id: I720b613f48ce29d4b63e4a4cd5c1c38bc351c4de
---
M modules/article/ext.proofreadpage.article.js
M modules/jquery/jquery.prpZoom.js
M modules/page/ext.proofreadpage.page.edit.js
3 files changed, 11 insertions(+), 10 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ProofreadPage
refs/changes/63/114463/1
diff --git a/modules/article/ext.proofreadpage.article.js
b/modules/article/ext.proofreadpage.article.js
index 18737ed..11c6e50 100644
--- a/modules/article/ext.proofreadpage.article.js
+++ b/modules/article/ext.proofreadpage.article.js
@@ -1,8 +1,9 @@
-// Author : ThomasV - License : GPL
+( function ( mw, $ ) {
+ 'use strict';
-/* add backlink to index page */
-function prAddSource() {
- $( '#ca-nstab-main' ).after( '<li id="ca-proofread-source"><span>' +
proofreadpage_source_href + '</span></li>' );
-}
+ $( document ).ready( function() {
+ /* add backlink to index page */
+ $( '#ca-nstab-main' ).after( '<li
id="ca-proofread-source"><span>' + mw.config.get( 'proofreadpage_source_href' )
+ '</span></li>' );
+ } );
-jQuery( prAddSource );
+} ( mediaWiki, jQuery ) );
\ No newline at end of file
diff --git a/modules/jquery/jquery.prpZoom.js b/modules/jquery/jquery.prpZoom.js
index 4423c81..52c40af 100644
--- a/modules/jquery/jquery.prpZoom.js
+++ b/modules/jquery/jquery.prpZoom.js
@@ -114,7 +114,7 @@
}
event.preventDefault(); //Don't scroll
while zooming
}
- }
+ };
},
reset: function() {
diff --git a/modules/page/ext.proofreadpage.page.edit.js
b/modules/page/ext.proofreadpage.page.edit.js
index 0009a02..969c852 100644
--- a/modules/page/ext.proofreadpage.page.edit.js
+++ b/modules/page/ext.proofreadpage.page.edit.js
@@ -92,10 +92,10 @@
*/
function setupPageQuality() {
$( 'input[name="wpQuality"]' ).click( function() {
+ var $summary = $( '#wpSummary' );
var pageQuality = mw.message( 'proofreadpage_quality' +
this.value + '_category').plain();
- var currentSummary = $( '#wpSummary' ).val();
- currentSummary = currentSummary.replace(
/\/\*.*\*\/\s?/, '' );
- $( '#wpSummary' ).val( '/* ' + pageQuality + ' */ ' +
currentSummary );
+ var summary = $summary.val().replace( /\/\*.*\*\/\s?/,
'' );
+ $summary.val( '/* ' + pageQuality + ' */ ' + summary );
} );
}
--
To view, visit https://gerrit.wikimedia.org/r/114463
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I720b613f48ce29d4b63e4a4cd5c1c38bc351c4de
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ProofreadPage
Gerrit-Branch: master
Gerrit-Owner: Tpt <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
