Aarcos has uploaded a new change for review.
https://gerrit.wikimedia.org/r/114631
Change subject: Remove fire_event("onfocus") from next/previous/exit actions,
not needed
......................................................................
Remove fire_event("onfocus") from next/previous/exit actions, not needed
As suggested by Chrismcmahon, I confirmed that there is no need
to fire the onfocus event.
Change-Id: I00ce04c758e496f76bd5c2a43ad933c952acc5fb
---
M tests/browser/features/support/pages/lightbox_demo_page.rb
1 file changed, 0 insertions(+), 3 deletions(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MultimediaViewer
refs/changes/31/114631/1
diff --git a/tests/browser/features/support/pages/lightbox_demo_page.rb
b/tests/browser/features/support/pages/lightbox_demo_page.rb
index 7620167..ffe8a41 100644
--- a/tests/browser/features/support/pages/lightbox_demo_page.rb
+++ b/tests/browser/features/support/pages/lightbox_demo_page.rb
@@ -40,17 +40,14 @@
# Convenient functions on some of these elements
def next_image()
- mmv_next_button_element.fire_event("onfocus")
mmv_next_button_element.when_present.click
end
def previous_image()
- mmv_previous_button_element.fire_event("onfocus")
mmv_previous_button_element.when_present.click
end
def exit_mmv()
- mmv_close_button_element.fire_event("onfocus")
mmv_close_button_element.when_present.click
end
--
To view, visit https://gerrit.wikimedia.org/r/114631
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I00ce04c758e496f76bd5c2a43ad933c952acc5fb
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MultimediaViewer
Gerrit-Branch: master
Gerrit-Owner: Aarcos <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
