jenkins-bot has submitted this change and it was merged.
Change subject: Remove fire_event("onfocus") from next/previous/exit actions,
not needed
......................................................................
Remove fire_event("onfocus") from next/previous/exit actions, not needed
As suggested by Chrismcmahon, I confirmed that there is no need
to fire the onfocus event. We also remove the convenient functions
around this logic.
Change-Id: I00ce04c758e496f76bd5c2a43ad933c952acc5fb
---
M tests/browser/features/step_definitions/basic_mmv_navigation_steps.rb
M tests/browser/features/support/pages/lightbox_demo_page.rb
2 files changed, 3 insertions(+), 20 deletions(-)
Approvals:
Cmcmahon: Looks good to me, approved
jenkins-bot: Verified
diff --git
a/tests/browser/features/step_definitions/basic_mmv_navigation_steps.rb
b/tests/browser/features/step_definitions/basic_mmv_navigation_steps.rb
index 6926554..fd831b0 100644
--- a/tests/browser/features/step_definitions/basic_mmv_navigation_steps.rb
+++ b/tests/browser/features/step_definitions/basic_mmv_navigation_steps.rb
@@ -11,19 +11,19 @@
When(/^I click the next arrow$/) do
on(LightboxDemoPage) do |page|
- page.next_image()
+ page.mmv_next_button_element.when_present.click
end
end
When(/^I click the previous arrow$/) do
on(LightboxDemoPage) do |page|
- page.previous_image()
+ page.mmv_previous_button_element.when_present.click
end
end
When(/^I close MMV$/) do
on(LightboxDemoPage) do |page|
- page.exit_mmv()
+ page.mmv_close_button_element.when_present.click
end
end
diff --git a/tests/browser/features/support/pages/lightbox_demo_page.rb
b/tests/browser/features/support/pages/lightbox_demo_page.rb
index 7620167..de48a07 100644
--- a/tests/browser/features/support/pages/lightbox_demo_page.rb
+++ b/tests/browser/features/support/pages/lightbox_demo_page.rb
@@ -37,21 +37,4 @@
div(:mmv_next_button, class: "mw-mlb-next-image")
div(:mmv_previous_button, class: "mw-mlb-prev-image")
div(:mmv_close_button, class: "mlb-close")
-
- # Convenient functions on some of these elements
- def next_image()
- mmv_next_button_element.fire_event("onfocus")
- mmv_next_button_element.when_present.click
- end
-
- def previous_image()
- mmv_previous_button_element.fire_event("onfocus")
- mmv_previous_button_element.when_present.click
- end
-
- def exit_mmv()
- mmv_close_button_element.fire_event("onfocus")
- mmv_close_button_element.when_present.click
- end
-
end
--
To view, visit https://gerrit.wikimedia.org/r/114631
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I00ce04c758e496f76bd5c2a43ad933c952acc5fb
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/MultimediaViewer
Gerrit-Branch: master
Gerrit-Owner: Aarcos <[email protected]>
Gerrit-Reviewer: Cmcmahon <[email protected]>
Gerrit-Reviewer: Jhall <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
