[MediaWiki-commits] [Gerrit] A cookie can optionally be set when starting the browser - change (mediawiki/selenium)

[Zfilipin (Code Review)]

Zfilipin has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/119487

Change subject: A cookie can optionally be set when starting the browser
......................................................................

A cookie can optionally be set when starting the browser

Paired with Chris McMahon.

Also extracted getting browser name to a method. Releasing 0.2.14 patch
version of the gem.

Bug: 62512
Change-Id: I0b647f98162d0070f3df8c14471d8d337daaca3f
---
M lib/mediawiki_selenium/support/env.rb
M lib/mediawiki_selenium/version.rb
2 files changed, 12 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/selenium 
refs/changes/87/119487/1

diff --git a/lib/mediawiki_selenium/support/env.rb 
b/lib/mediawiki_selenium/support/env.rb
index 1539106..4283a71 100644
--- a/lib/mediawiki_selenium/support/env.rb
+++ b/lib/mediawiki_selenium/support/env.rb
@@ -26,6 +26,13 @@
     local_browser(configuration)
   end
 end
+def browser_name
+  if ENV["BROWSER"]
+    ENV["BROWSER"].to_sym
+  else
+    :firefox
+  end
+end
 def environment
   if ENV["SAUCE_ONDEMAND_USERNAME"] and ENV["SAUCE_ONDEMAND_ACCESS_KEY"] and 
ENV["BROWSER"] != "phantomjs"
     :saucelabs
@@ -34,12 +41,6 @@
   end
 end
 def local_browser(configuration)
-  if ENV["BROWSER"]
-    browser_name = ENV["BROWSER"].to_sym
-  else
-    browser_name = :firefox
-  end
-
   if ENV["BROWSER_TIMEOUT"] && browser_name == :firefox
     timeout = ENV["BROWSER_TIMEOUT"].to_i
 
@@ -70,6 +71,7 @@
   end
 
   browser.window.resize_to 1280, 1024
+  set_cookie
   browser
 end
 def sauce_api(json)
@@ -129,6 +131,9 @@
 
   browser
 end
+def set_cookie
+  # implement this method in env.rb of the repository where it is needed
+end
 def test_name(scenario)
   if scenario.respond_to? :feature
     "#{scenario.feature.name}: #{scenario.name}"
diff --git a/lib/mediawiki_selenium/version.rb 
b/lib/mediawiki_selenium/version.rb
index 40e1aa8..d2af553 100644
--- a/lib/mediawiki_selenium/version.rb
+++ b/lib/mediawiki_selenium/version.rb
@@ -10,5 +10,5 @@
 =end
 
 module MediawikiSelenium
-  VERSION = "0.2.13"
+  VERSION = "0.2.14"
 end

-- 
To view, visit https://gerrit.wikimedia.org/r/119487
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I0b647f98162d0070f3df8c14471d8d337daaca3f
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/selenium
Gerrit-Branch: master
Gerrit-Owner: Zfilipin <zfili...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits