Cmcmahon has submitted this change and it was merged.
Change subject: A cookie can optionally be set when starting the browser
......................................................................
A cookie can optionally be set when starting the browser
Paired with Chris McMahon.
Also extracted getting browser name to a method. Releasing 0.2.14 patch
version of the gem.
Bug: 62512
Change-Id: I0b647f98162d0070f3df8c14471d8d337daaca3f
---
M lib/mediawiki_selenium/support/env.rb
M lib/mediawiki_selenium/version.rb
2 files changed, 12 insertions(+), 7 deletions(-)
Approvals:
Cmcmahon: Looks good to me, approved
jenkins-bot: Verified
diff --git a/lib/mediawiki_selenium/support/env.rb
b/lib/mediawiki_selenium/support/env.rb
index 1539106..4283a71 100644
--- a/lib/mediawiki_selenium/support/env.rb
+++ b/lib/mediawiki_selenium/support/env.rb
@@ -26,6 +26,13 @@
local_browser(configuration)
end
end
+def browser_name
+ if ENV["BROWSER"]
+ ENV["BROWSER"].to_sym
+ else
+ :firefox
+ end
+end
def environment
if ENV["SAUCE_ONDEMAND_USERNAME"] and ENV["SAUCE_ONDEMAND_ACCESS_KEY"] and
ENV["BROWSER"] != "phantomjs"
:saucelabs
@@ -34,12 +41,6 @@
end
end
def local_browser(configuration)
- if ENV["BROWSER"]
- browser_name = ENV["BROWSER"].to_sym
- else
- browser_name = :firefox
- end
-
if ENV["BROWSER_TIMEOUT"] && browser_name == :firefox
timeout = ENV["BROWSER_TIMEOUT"].to_i
@@ -70,6 +71,7 @@
end
browser.window.resize_to 1280, 1024
+ set_cookie
browser
end
def sauce_api(json)
@@ -129,6 +131,9 @@
browser
end
+def set_cookie
+ # implement this method in env.rb of the repository where it is needed
+end
def test_name(scenario)
if scenario.respond_to? :feature
"#{scenario.feature.name}: #{scenario.name}"
diff --git a/lib/mediawiki_selenium/version.rb
b/lib/mediawiki_selenium/version.rb
index 40e1aa8..d2af553 100644
--- a/lib/mediawiki_selenium/version.rb
+++ b/lib/mediawiki_selenium/version.rb
@@ -10,5 +10,5 @@
=end
module MediawikiSelenium
- VERSION = "0.2.13"
+ VERSION = "0.2.14"
end
--
To view, visit https://gerrit.wikimedia.org/r/119487
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0b647f98162d0070f3df8c14471d8d337daaca3f
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/selenium
Gerrit-Branch: master
Gerrit-Owner: Zfilipin <[email protected]>
Gerrit-Reviewer: Amire80 <[email protected]>
Gerrit-Reviewer: Cmcmahon <[email protected]>
Gerrit-Reviewer: JGonera <[email protected]>
Gerrit-Reviewer: Jdlrobson <[email protected]>
Gerrit-Reviewer: KartikMistry <[email protected]>
Gerrit-Reviewer: Manybubbles <[email protected]>
Gerrit-Reviewer: Tobias Gritschacher <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
