jenkins-bot has submitted this change and it was merged.
Change subject: Improve code for setting bot param, with isset check as added
in Ie0650eb
......................................................................
Improve code for setting bot param, with isset check as added in Ie0650eb
Change-Id: I8321ed4249e8d993adf1ea1724e45af1d16c9803
---
M repo/includes/api/ApiWikibase.php
1 file changed, 3 insertions(+), 1 deletion(-)
Approvals:
WikidataJenkins: Verified
Thiemo Mättig (WMDE): Looks good to me, approved
jenkins-bot: Verified
diff --git a/repo/includes/api/ApiWikibase.php
b/repo/includes/api/ApiWikibase.php
index 81db295..bc76c4b 100644
--- a/repo/includes/api/ApiWikibase.php
+++ b/repo/includes/api/ApiWikibase.php
@@ -477,7 +477,9 @@
$params = $this->extractRequestParams();
$user = $this->getUser();
- $flags |= ( $user->isAllowed( 'bot' ) && $params['bot'] ) ?
EDIT_FORCE_BOT : 0;
+ if ( isset( $params['bot'] ) && $params['bot'] &&
$user->isAllowed( 'bot' ) ) {
+ $flags |= EDIT_FORCE_BOT;
+ }
$baseRevisionId = isset( $params['baserevid'] ) ? intval(
$params['baserevid'] ) : null;
$baseRevisionId = $baseRevisionId > 0 ? $baseRevisionId : false;
--
To view, visit https://gerrit.wikimedia.org/r/119729
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8321ed4249e8d993adf1ea1724e45af1d16c9803
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Aude <[email protected]>
Gerrit-Reviewer: Thiemo Mättig (WMDE) <[email protected]>
Gerrit-Reviewer: WikidataJenkins <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
