Aude has uploaded a new change for review.
https://gerrit.wikimedia.org/r/119773
Change subject: Improve code for setting bot param, with isset check as added
in Ie0650eb
......................................................................
Improve code for setting bot param, with isset check as added in Ie0650eb
cherry-pick
Change-Id: I8321ed4249e8d993adf1ea1724e45af1d16c9803
---
M repo/includes/api/ApiWikibase.php
1 file changed, 3 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase
refs/changes/73/119773/1
diff --git a/repo/includes/api/ApiWikibase.php
b/repo/includes/api/ApiWikibase.php
index 10dc42c..bc76c4b 100644
--- a/repo/includes/api/ApiWikibase.php
+++ b/repo/includes/api/ApiWikibase.php
@@ -477,8 +477,9 @@
$params = $this->extractRequestParams();
$user = $this->getUser();
- $bot = isset( $params['bot'] ) ? $params['bot'] : false;
- $flags |= ( $bot && $user->isAllowed( 'bot' ) ) ?
EDIT_FORCE_BOT : 0;
+ if ( isset( $params['bot'] ) && $params['bot'] &&
$user->isAllowed( 'bot' ) ) {
+ $flags |= EDIT_FORCE_BOT;
+ }
$baseRevisionId = isset( $params['baserevid'] ) ? intval(
$params['baserevid'] ) : null;
$baseRevisionId = $baseRevisionId > 0 ? $baseRevisionId : false;
--
To view, visit https://gerrit.wikimedia.org/r/119773
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8321ed4249e8d993adf1ea1724e45af1d16c9803
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: mw1.23-wmf19
Gerrit-Owner: Aude <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
