KartikMistry has uploaded a new change for review. https://gerrit.wikimedia.org/r/122652
Change subject: shellcheck fixes. ...................................................................... shellcheck fixes. * Script: https://github.com/koalaman/shellcheck * Use $(..) instead of deprecated `..` * Use double quote to prevent globbing and word splitting. Change-Id: I68372d4e29ae34e0704e5a605447ad17bf0666d7 --- M scripts/update-jquery-i18n.sh M scripts/update-jquery-ime.sh M scripts/update-jquery-uls.sh M scripts/update-jquery-webfonts.sh 4 files changed, 8 insertions(+), 8 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/UniversalLanguageSelector refs/changes/52/122652/1 diff --git a/scripts/update-jquery-i18n.sh b/scripts/update-jquery-i18n.sh index 321e124..537164b 100755 --- a/scripts/update-jquery-i18n.sh +++ b/scripts/update-jquery-i18n.sh @@ -2,7 +2,7 @@ DEST="../lib/jquery.i18n"; CLONEDIR="/tmp/jquery.i18n"; -HERE=`pwd`; +HERE=$(pwd); UPSTREAM="https://github.com/wikimedia/jquery.i18n.git";; echo -e "Getting latest jquery.i18n from $UPSTREAM\n"; @@ -13,5 +13,5 @@ git clone $UPSTREAM $CLONEDIR; fi -cd $HERE; +cd "$HERE"; cp -rf $CLONEDIR/src/* $DEST diff --git a/scripts/update-jquery-ime.sh b/scripts/update-jquery-ime.sh index 1c01347..bb5e8b2 100755 --- a/scripts/update-jquery-ime.sh +++ b/scripts/update-jquery-ime.sh @@ -2,7 +2,7 @@ DEST="../lib/jquery.ime"; CLONEDIR="/tmp/jquery.ime"; -HERE=`pwd`; +HERE=$(pwd); UPSTREAM="https://github.com/wikimedia/jquery.ime.git";; echo -e "Getting latest jquery.ime from $UPSTREAM\n"; @@ -16,5 +16,5 @@ cd $CLONEDIR; npm install; grunt copy concat; -cd $HERE; +cd "$HERE"; cp -rf $CLONEDIR/dist/jquery.ime/{images,css,rules,jquery.ime.js} $DEST; diff --git a/scripts/update-jquery-uls.sh b/scripts/update-jquery-uls.sh index bf6282c..8797d66 100755 --- a/scripts/update-jquery-uls.sh +++ b/scripts/update-jquery-uls.sh @@ -2,7 +2,7 @@ DEST="../lib/jquery.uls"; CLONEDIR="/tmp/jquery.uls"; -HERE=`pwd`; +HERE=$(pwd); UPSTREAM="https://github.com/wikimedia/jquery.uls.git";; echo -e "Getting latest jquery.uls from $UPSTREAM\n"; @@ -13,5 +13,5 @@ git clone $UPSTREAM $CLONEDIR; fi -cd $HERE; +cd "$HERE"; cp -rf $CLONEDIR/{images,css,src,i18n} $DEST diff --git a/scripts/update-jquery-webfonts.sh b/scripts/update-jquery-webfonts.sh index c2c1e65..f2ff811 100755 --- a/scripts/update-jquery-webfonts.sh +++ b/scripts/update-jquery-webfonts.sh @@ -2,7 +2,7 @@ DEST="../lib/"; CLONEDIR="/tmp/jquery.webfonts"; -HERE=`pwd`; +HERE=$(pwd); UPSTREAM="https://github.com/wikimedia/jquery.webfonts.git";; echo -e "Getting latest jquery.webfonts from $UPSTREAM\n"; @@ -13,5 +13,5 @@ git clone $UPSTREAM $CLONEDIR; fi -cd $HERE; +cd "$HERE"; cp -rf $CLONEDIR/src/* $DEST -- To view, visit https://gerrit.wikimedia.org/r/122652 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I68372d4e29ae34e0704e5a605447ad17bf0666d7 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/UniversalLanguageSelector Gerrit-Branch: master Gerrit-Owner: KartikMistry <[email protected]> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
