KartikMistry has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/122653

Change subject: bin/generateDocs fixes
......................................................................

bin/generateDocs fixes

* Fix bin/generateDocs as per shellcheck (quote to prevent word
splitting).
* Add generated docs folder to .gitignore

Change-Id: I1922b42a7a55aea88362fd70914b251156eb8267
---
M .gitignore
M bin/generateDocs.sh
2 files changed, 6 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/services/cxserver 
refs/changes/53/122653/1

diff --git a/.gitignore b/.gitignore
index 5974f40..7320aa2 100644
--- a/.gitignore
+++ b/.gitignore
@@ -5,4 +5,5 @@
 .idea
 .bundle/
 config.js
+docs
 node_modules
diff --git a/bin/generateDocs.sh b/bin/generateDocs.sh
index ecf764f..7fd1b24 100755
--- a/bin/generateDocs.sh
+++ b/bin/generateDocs.sh
@@ -1,6 +1,9 @@
-#!/usr/bin/env bash
+#!/bin/bash
+
 set -e
-cd $(cd $(dirname $0)/..; pwd)
+
+cd "$(cd "$(dirname "$0")"/..; pwd)"
 
 version=$(node -e 
'console.log(JSON.parse(require("fs").readFileSync("package.json")).version);')
+
 jsduck --config jsduck.config.json --footer "Documentation for 
ContentTranslation v$version."

-- 
To view, visit https://gerrit.wikimedia.org/r/122653
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I1922b42a7a55aea88362fd70914b251156eb8267
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/cxserver
Gerrit-Branch: master
Gerrit-Owner: KartikMistry <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to