jenkins-bot has submitted this change and it was merged.

Change subject: If environment variable HEADLESS is set to true, run a local 
browser
......................................................................


If environment variable HEADLESS is set to true, run a local browser

This makes it possible to run on a local Firefox (and Chrome) on a
Jenkins machine.

Also releasing patch version 0.2.18.

Paired with: Tobias Gritschacher

Change-Id: I8c6b57f827d57c6f5272ade5f0588249862bbf59
---
M lib/mediawiki_selenium/support/env.rb
M lib/mediawiki_selenium/version.rb
2 files changed, 2 insertions(+), 2 deletions(-)

Approvals:
  KartikMistry: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/lib/mediawiki_selenium/support/env.rb 
b/lib/mediawiki_selenium/support/env.rb
index 36ec949..ed77930 100644
--- a/lib/mediawiki_selenium/support/env.rb
+++ b/lib/mediawiki_selenium/support/env.rb
@@ -34,7 +34,7 @@
   end
 end
 def environment
-  if ENV["SAUCE_ONDEMAND_USERNAME"] and ENV["SAUCE_ONDEMAND_ACCESS_KEY"] and 
ENV["BROWSER"] != "phantomjs"
+  if ENV["SAUCE_ONDEMAND_USERNAME"] and ENV["SAUCE_ONDEMAND_ACCESS_KEY"] and 
ENV["BROWSER"] != "phantomjs" and ENV["HEADLESS"] != "true"
     :saucelabs
   else
     :local
diff --git a/lib/mediawiki_selenium/version.rb 
b/lib/mediawiki_selenium/version.rb
index 9d55c13..cb98527 100644
--- a/lib/mediawiki_selenium/version.rb
+++ b/lib/mediawiki_selenium/version.rb
@@ -10,5 +10,5 @@
 =end
 
 module MediawikiSelenium
-  VERSION = "0.2.17"
+  VERSION = "0.2.18"
 end

-- 
To view, visit https://gerrit.wikimedia.org/r/125169
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I8c6b57f827d57c6f5272ade5f0588249862bbf59
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/selenium
Gerrit-Branch: master
Gerrit-Owner: Zfilipin <[email protected]>
Gerrit-Reviewer: Amire80 <[email protected]>
Gerrit-Reviewer: Cmcmahon <[email protected]>
Gerrit-Reviewer: KartikMistry <[email protected]>
Gerrit-Reviewer: Manybubbles <[email protected]>
Gerrit-Reviewer: Tobias Gritschacher <[email protected]>
Gerrit-Reviewer: Zfilipin <[email protected]>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to