Robmoen has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/132963

Change subject: Show anonymous acquisition experiment once regardless of page 
load.
......................................................................

Show anonymous acquisition experiment once regardless of page load.

Change-Id: I0300c7f27a599343bd75495a59b93e0d3cf607ba
---
M resources/ext.gettingstarted.anonymousEditorAcquisition.js
1 file changed, 12 insertions(+), 8 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/GettingStarted 
refs/changes/63/132963/1

diff --git a/resources/ext.gettingstarted.anonymousEditorAcquisition.js 
b/resources/ext.gettingstarted.anonymousEditorAcquisition.js
index 72e47d8..51f067f 100644
--- a/resources/ext.gettingstarted.anonymousEditorAcquisition.js
+++ b/resources/ext.gettingstarted.anonymousEditorAcquisition.js
@@ -140,15 +140,25 @@
                                unregisterPreEditVariant();
 
                                mw.libs.guiders.reposition();
-                               gt.launchTour( tour );
+                               launchTour( tour );
                        } );
                } );
        }
 
        function initPostEditVariant() {
                mw.hook( 'postEdit' ).add( function () {
-                       gt.launchTour( 'anonymouseditoracquisitionpostedit' );
+                       launchTour( 'anonymouseditoracquisitionpostedit' );
                } );
+       }
+
+       // Launch tour if the user has not seen the CTA from either bucket.
+       function launchTour( tourName ) {
+               // Only init if user has not seen CTA.
+               if ( $.jStorage.get( 'hasShownAnonymousEditorAcquisitionCTA' ) 
) {
+                       return;
+               }
+               $.jStorage.set( 'hasShownAnonymousEditorAcquisitionCTA', true );
+               gt.launchTour( tourName );
        }
 
        mw.gettingStarted = mw.gettingStarted || {};
@@ -281,12 +291,6 @@
                logLinkClick( '.mw-editsection a', 'edit section', !isPreEdit );
 
                logLinkClick( '#pt-createaccount', 'create account' );
-
-               // Only init if user has not seen CTA.
-               if ( $.jStorage.get( 'hasShownAnonymousEditorAcquisitionCTA' ) 
) {
-                       return;
-               }
-               $.jStorage.set( 'hasShownAnonymousEditorAcquisitionCTA', true );
 
                if ( isPreEdit ) {
                        initPreEditVariant();

-- 
To view, visit https://gerrit.wikimedia.org/r/132963
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I0300c7f27a599343bd75495a59b93e0d3cf607ba
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/GettingStarted
Gerrit-Branch: master
Gerrit-Owner: Robmoen <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to