jenkins-bot has submitted this change and it was merged.
Change subject: Show anonymous acquisition experiment once regardless of page
load.
......................................................................
Show anonymous acquisition experiment once regardless of page load.
Change-Id: I0300c7f27a599343bd75495a59b93e0d3cf607ba
(cherry picked from commit e4c79ddb9f3cc940dd4e86c5a72db10bfc4cdc95)
---
M resources/ext.gettingstarted.anonymousEditorAcquisition.js
1 file changed, 20 insertions(+), 13 deletions(-)
Approvals:
Mattflaschen: Looks good to me, approved
jenkins-bot: Verified
diff --git a/resources/ext.gettingstarted.anonymousEditorAcquisition.js
b/resources/ext.gettingstarted.anonymousEditorAcquisition.js
index 72e47d8..d2b5878 100644
--- a/resources/ext.gettingstarted.anonymousEditorAcquisition.js
+++ b/resources/ext.gettingstarted.anonymousEditorAcquisition.js
@@ -7,6 +7,7 @@
token = user.getToken(),
bucket = user.getBucket(),
LOG_EVENT_TIMEOUT = 500, // (ms)
+ CTA_FLAG_KEY = 'hasShownAnonymousEditorAcquisitionCTA',
tourToSelectorMapping = {
'anonymouseditoracquisitionpreedit': [ '#ca-edit',
'.mw-editsection a:not( .mw-editsection-visualeditor )' ],
'anonymouseditoracquisitionpreeditve': [ '#ca-ve-edit',
'.mw-editsection-visualeditor ' ]
@@ -140,15 +141,25 @@
unregisterPreEditVariant();
mw.libs.guiders.reposition();
- gt.launchTour( tour );
+ launchTour( tour );
} );
} );
}
function initPostEditVariant() {
mw.hook( 'postEdit' ).add( function () {
- gt.launchTour( 'anonymouseditoracquisitionpostedit' );
+ launchTour( 'anonymouseditoracquisitionpostedit' );
} );
+ }
+
+ // Wrapper for launching the experiment tour
+ function launchTour( tourName ) {
+ // Abort if flag is set
+ if ( $.jStorage.get( CTA_FLAG_KEY ) ) {
+ return;
+ }
+ $.jStorage.set( CTA_FLAG_KEY, true );
+ gt.launchTour( tourName );
}
mw.gettingStarted = mw.gettingStarted || {};
@@ -279,19 +290,15 @@
// SignupExpPageLinkClick event has been logged.
logLinkClick( [ '#ca-edit', '#ca-ve-edit' ], 'edit page',
!isPreEdit );
logLinkClick( '.mw-editsection a', 'edit section', !isPreEdit );
-
logLinkClick( '#pt-createaccount', 'create account' );
- // Only init if user has not seen CTA.
- if ( $.jStorage.get( 'hasShownAnonymousEditorAcquisitionCTA' )
) {
- return;
- }
- $.jStorage.set( 'hasShownAnonymousEditorAcquisitionCTA', true );
-
- if ( isPreEdit ) {
- initPreEditVariant();
- } else if ( bucket === 'post-edit' ) {
- initPostEditVariant();
+ // Init if flag is not set
+ if ( $.jStorage.get( CTA_FLAG_KEY ) === null ) {
+ if ( isPreEdit ) {
+ initPreEditVariant();
+ } else if ( bucket === 'post-edit' ) {
+ initPostEditVariant();
+ }
}
} );
--
To view, visit https://gerrit.wikimedia.org/r/133611
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0300c7f27a599343bd75495a59b93e0d3cf607ba
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/GettingStarted
Gerrit-Branch: wmf/1.24wmf4
Gerrit-Owner: Phuedx <[email protected]>
Gerrit-Reviewer: Mattflaschen <[email protected]>
Gerrit-Reviewer: Robmoen <[email protected]>
Gerrit-Reviewer: Swalling <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
