Henning Snater has submitted this change and it was merged. Change subject: Fix QUnit test for EditableValue which assumed initially not in edit mode ......................................................................
Fix QUnit test for EditableValue which assumed initially not in edit mode This is a false assumption which was true in the past. Since we display empty input fields initially if the EditableValue is empty this test should have failed. This was not the case because of DOM changes which were not adjusted in the test file so there was a value set initially so the EditableValue never was in edit mode initially. Change-Id: I0099c9a951cb87de53bef11c5a6baa02e9c0954d --- M repo/tests/qunit/wikibase.ui.PropertyEditTool.EditableValue.tests.js 1 file changed, 8 insertions(+), 2 deletions(-) Approvals: Henning Snater: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/26647 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0099c9a951cb87de53bef11c5a6baa02e9c0954d Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Daniel Werner <[email protected]> Gerrit-Reviewer: Henning Snater <[email protected]> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
