Krinkle has uploaded a new change for review.
https://gerrit.wikimedia.org/r/140651
Change subject: qunit.completenessTest: Don't break mw.log methods
......................................................................
qunit.completenessTest: Don't break mw.log methods
Due to the QUnit CompletenessTest injecting a spy in mw.log,
things like mw.log.warn became undefined and causing exceptions
to be thrown sometimes.
Change-Id: If16db9337a99865ada0fe1c482dd62a572239030
---
M tests/qunit/data/testrunner.js
1 file changed, 6 insertions(+), 0 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/51/140651/1
diff --git a/tests/qunit/data/testrunner.js b/tests/qunit/data/testrunner.js
index ab9aab1..365f5df 100644
--- a/tests/qunit/data/testrunner.js
+++ b/tests/qunit/data/testrunner.js
@@ -136,6 +136,12 @@
return true;
}
+ // Don't inject a spy in mw.log. Overriding it will
blow away
+ // mw.log.warn etc.
+ if ( val === mw.log ) {
+ return true;
+ }
+
return false;
};
--
To view, visit https://gerrit.wikimedia.org/r/140651
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: If16db9337a99865ada0fe1c482dd62a572239030
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Krinkle <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
