Krinkle has uploaded a new change for review.
https://gerrit.wikimedia.org/r/140653
Change subject: qunit.completenessTest: Ignore mw.loader.moduleRegistry
......................................................................
qunit.completenessTest: Ignore mw.loader.moduleRegistry
It was iterating over it and considering its 'script' properties
to be methods that had to be tested.
The CompletnessTest before this change is filled with stuff like:
- loader.moduleRegistry.skins.vector.js.script
- loader.moduleRegistry.mediawiki.api.script
- loader.moduleRegistry.mediawiki.Title.script
- ..
And was actually causing it to hit hard limit and thus actual
lots of actual methods were no longer inspected by the test.
Change-Id: I13fbf1224b48aa34a7bb01fdc0543023e502bb4f
---
M tests/qunit/data/testrunner.js
1 file changed, 6 insertions(+), 0 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/53/140653/1
diff --git a/tests/qunit/data/testrunner.js b/tests/qunit/data/testrunner.js
index 365f5df..b2844c0 100644
--- a/tests/qunit/data/testrunner.js
+++ b/tests/qunit/data/testrunner.js
@@ -142,6 +142,12 @@
return true;
}
+ // Don't iterate over the module registry (the 'script'
references would
+ // be listed as untested methods otherwise)
+ if ( val === mw.loader.moduleRegistry ) {
+ //return true;
+ }
+
return false;
};
--
To view, visit https://gerrit.wikimedia.org/r/140653
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I13fbf1224b48aa34a7bb01fdc0543023e502bb4f
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Krinkle <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
