Mpaa has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/143056

Change subject: site.py: pyflakes fixes
......................................................................

site.py: pyflakes fixes

- local variable 'filterredirs' is assigned to but never used
   wrong name -> renamed to filterredir

- local variable 'prev_user' is assigned to but never used

Change-Id: I79660f877102472fcab00732f9f0c310bea3a0c8
---
M pywikibot/site.py
1 file changed, 5 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/pywikibot/core 
refs/changes/56/143056/1

diff --git a/pywikibot/site.py b/pywikibot/site.py
index 3b4d817..f9f090a 100644
--- a/pywikibot/site.py
+++ b/pywikibot/site.py
@@ -2037,7 +2037,7 @@
             level; can only be used if protect_type is specified
         @param reverse: if True, iterate in reverse Unicode lexigraphic
             order (default: iterate in forward order)
-        @param includeredirects: DEPRECATED, use filterredirs instead
+        @param includeredirects: DEPRECATED, use filterredir instead
         @param content: if True, load the current content of each iterated page
             (default False)
 
@@ -2047,15 +2047,15 @@
         if includeredirects is not None:
             pywikibot.debug(
                 u"allpages: 'includeRedirects' argument is deprecated; "
-                u"use 'filterredirs'.",
+                u"use 'filterredir'.",
                 _logger)
             if includeredirects:
                 if includeredirects == "only":
-                    filterredirs = True
+                    filterredir = True
                 else:
-                    filterredirs = None
+                    filterredir = None
             else:
-                filterredirs = False
+                filterredir = False
 
         apgen = self._generator(api.PageGenerator, type_arg="allpages",
                                 gapnamespace=str(namespace),
@@ -3035,7 +3035,6 @@
         for rev in sorted(list(page._revisions.keys()), reverse=True):
             # start with most recent revision first
             if rev.user != last_user:
-                prev_user = rev.user
                 break
         else:
             raise pywikibot.Error(

-- 
To view, visit https://gerrit.wikimedia.org/r/143056
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I79660f877102472fcab00732f9f0c310bea3a0c8
Gerrit-PatchSet: 1
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Owner: Mpaa <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to