Martineznovo has uploaded a new change for review.
https://gerrit.wikimedia.org/r/145409
Change subject: Handle invalid language code gracefully in
Language::fetchLanguageNames
......................................................................
Handle invalid language code gracefully in Language::fetchLanguageNames
Core MW doesn't have a problem, but translate extension explodes.
Seems safer to just use 'en' if passed an invalid language code.
Bug: 60629
Change-Id: I0ede3169bb49001a1515ae5b2b6d28477704f346
(cherry picked from commit 634905558b2b2a658d55ee98b3200d9bd0731fe4)
---
M languages/Language.php
1 file changed, 5 insertions(+), 0 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/09/145409/1
diff --git a/languages/Language.php b/languages/Language.php
index 1ad2b7a..e7f11d3 100644
--- a/languages/Language.php
+++ b/languages/Language.php
@@ -883,6 +883,11 @@
include "$IP/languages/Names.php";
}
+ // If passed an invalid language code to use, fallback to en
+ if ( $inLanguage !== null && !Language::isValidCode(
$inLanguage ) ) {
+ $inLanguage = 'en';
+ }
+
$names = array();
if ( $inLanguage ) {
--
To view, visit https://gerrit.wikimedia.org/r/145409
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0ede3169bb49001a1515ae5b2b6d28477704f346
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: REL1_23
Gerrit-Owner: Martineznovo <[email protected]>
Gerrit-Reviewer: Brian Wolff <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
