Hello Milimetric,
I'd like you to do a code review. Please visit
https://gerrit.wikimedia.org/r/149301
to review the following change.
Change subject: Drop noop assertion in connection pool test
......................................................................
Drop noop assertion in connection pool test
Change-Id: I528daf5642f41550cec70f9f6f6c723f4ef9b694
---
M tests/manual/connection_pool_configuration.py
1 file changed, 1 insertion(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/analytics/wikimetrics
refs/changes/01/149301/1
diff --git a/tests/manual/connection_pool_configuration.py
b/tests/manual/connection_pool_configuration.py
index 301048c..8801684 100644
--- a/tests/manual/connection_pool_configuration.py
+++ b/tests/manual/connection_pool_configuration.py
@@ -1,6 +1,6 @@
from unittest import TestCase
from sqlalchemy.exc import TimeoutError
-from nose.tools import assert_true, raises
+from nose.tools import raises
from tests.fixtures import mediawiki_project
from wikimetrics.configurables import db, parse_db_connection_string, queue
@@ -29,7 +29,6 @@
for i in range(pool_size)
]
[self.sessions[i].query(Page).first() for i in range(pool_size)]
- assert_true(True)
def tearDown(self):
if hasattr(self, 'sessions'):
--
To view, visit https://gerrit.wikimedia.org/r/149301
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I528daf5642f41550cec70f9f6f6c723f4ef9b694
Gerrit-PatchSet: 1
Gerrit-Project: analytics/wikimetrics
Gerrit-Branch: master
Gerrit-Owner: QChris <[email protected]>
Gerrit-Reviewer: Milimetric <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
