Hello Milimetric,
I'd like you to do a code review. Please visit
https://gerrit.wikimedia.org/r/149300
to review the following change.
Change subject: Be lighter on database when testing connection pools
......................................................................
Be lighter on database when testing connection pools
Change-Id: Ie86ea0d8de09b136ac957a07218c1d8930357f46
---
M tests/manual/connection_pool_configuration.py
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/analytics/wikimetrics
refs/changes/00/149300/1
diff --git a/tests/manual/connection_pool_configuration.py
b/tests/manual/connection_pool_configuration.py
index a6fe7bc..301048c 100644
--- a/tests/manual/connection_pool_configuration.py
+++ b/tests/manual/connection_pool_configuration.py
@@ -20,7 +20,7 @@
db.get_mw_session(mediawiki_project)
for i in range(pool_size)
]
- [self.sessions[i].query(Page).all() for i in range(pool_size)]
+ [self.sessions[i].query(Page).first() for i in range(pool_size)]
def test_pool_size_is_used(self):
pool_size = db.config['MEDIAWIKI_POOL_SIZE']
@@ -28,7 +28,7 @@
db.get_mw_session(mediawiki_project)
for i in range(pool_size)
]
- [self.sessions[i].query(Page).all() for i in range(pool_size)]
+ [self.sessions[i].query(Page).first() for i in range(pool_size)]
assert_true(True)
def tearDown(self):
--
To view, visit https://gerrit.wikimedia.org/r/149300
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie86ea0d8de09b136ac957a07218c1d8930357f46
Gerrit-PatchSet: 1
Gerrit-Project: analytics/wikimetrics
Gerrit-Branch: master
Gerrit-Owner: QChris <[email protected]>
Gerrit-Reviewer: Milimetric <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
