jenkins-bot has submitted this change and it was merged.
Change subject: Remove @todo in SpecialPage for making it into ContextSource
......................................................................
Remove @todo in SpecialPage for making it into ContextSource
It is better to have $context as a member variable,
which can be accessed, $special->getContext(), as needed
with a composition approach instead of inheritance.
Having SpecialPage directly inherit makes testing code
a bit more challenging and messy.
Change-Id: I5e5587cbbc9abfb2fa4ab1e7603cd2ddcad1b96d
---
M includes/specialpage/SpecialPage.php
1 file changed, 0 insertions(+), 1 deletion(-)
Approvals:
Hoo man: Looks good to me, but someone else must approve
Legoktm: Looks good to me, approved
Daniel Kinzler: Looks good to me, but someone else must approve
jenkins-bot: Verified
diff --git a/includes/specialpage/SpecialPage.php
b/includes/specialpage/SpecialPage.php
index a72b297..4edd87a 100644
--- a/includes/specialpage/SpecialPage.php
+++ b/includes/specialpage/SpecialPage.php
@@ -27,7 +27,6 @@
* Includes some static functions for handling the special page list deprecated
* in favor of SpecialPageFactory.
*
- * @todo Turn this into a real ContextSource
* @ingroup SpecialPage
*/
class SpecialPage {
--
To view, visit https://gerrit.wikimedia.org/r/148996
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5e5587cbbc9abfb2fa4ab1e7603cd2ddcad1b96d
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Aude <[email protected]>
Gerrit-Reviewer: Aude <[email protected]>
Gerrit-Reviewer: Daniel Kinzler <[email protected]>
Gerrit-Reviewer: Hoo man <[email protected]>
Gerrit-Reviewer: Legoktm <[email protected]>
Gerrit-Reviewer: Withoutaname <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
