Jeroen De Dauw has uploaded a new change for review.
https://gerrit.wikimedia.org/r/153700
Change subject: Remove dead code
......................................................................
Remove dead code
Change-Id: I948b69d396c1b63c59738fca3fbbb1d03fe07719
---
M client/includes/UpdateRepo.php
1 file changed, 1 insertion(+), 13 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase
refs/changes/00/153700/1
diff --git a/client/includes/UpdateRepo.php b/client/includes/UpdateRepo.php
index 4a5088a..58804bd 100644
--- a/client/includes/UpdateRepo.php
+++ b/client/includes/UpdateRepo.php
@@ -136,20 +136,8 @@
$job = $this->createJob();
wfProfileIn( __METHOD__ . '#push' );
- $result = $jobQueueGroup->push( $job );
+ $jobQueueGroup->push( $job );
wfProfileOut( __METHOD__ . '#push' );
-
- // MediaWiki 1.24+ throws exceptions on error instead of
returning false,
- // but JobQueueGroup::push returns a useless true value.
- //
- // We do explicit check for false, for backwards compatibility
with MediaWiki 1.23
- // and to make robust in case the useless true return value is
removed in core.
- //
- // @todo The check can be removed when we do not support 1.23
anymore.
- if ( $result === false ) {
- wfProfileOut( __METHOD__ );
- throw new RuntimeException( "Failed to push job to job
queue" );
- }
wfProfileOut( __METHOD__ );
}
--
To view, visit https://gerrit.wikimedia.org/r/153700
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I948b69d396c1b63c59738fca3fbbb1d03fe07719
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Jeroen De Dauw <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
