[MediaWiki-commits] [Gerrit] Minor tweak in PopulateInterwiki - change (mediawiki...Wikibase)

[Jeroen De Dauw (Code Review)]

Jeroen De Dauw has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/153701

Change subject: Minor tweak in PopulateInterwiki
......................................................................

Minor tweak in PopulateInterwiki

Change-Id: I2f6fc0139b3ffa6ab70420207710ef0e23fbceed
---
M client/maintenance/populateInterwiki.php
1 file changed, 1 insertion(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase 
refs/changes/01/153701/1

diff --git a/client/maintenance/populateInterwiki.php 
b/client/maintenance/populateInterwiki.php
index 2ac2e5a..1f618cf 100644
--- a/client/maintenance/populateInterwiki.php
+++ b/client/maintenance/populateInterwiki.php
@@ -65,9 +65,8 @@
                );
 
                // todo: is valid
-               if ( !empty ( $this->source ) ) {
+               if ( !empty( $this->source ) ) {
                        try {
-                               // make sure this has the '?'
                                $baseUrl = rtrim( $this->source, '?' ) . '?';
                        } catch( Exception $e ) {
                                $this->error( "Error: Invalid api source" );

-- 
To view, visit https://gerrit.wikimedia.org/r/153701
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I2f6fc0139b3ffa6ab70420207710ef0e23fbceed
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Jeroen De Dauw <jeroended...@gmail.com>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits