Cmcmahon has uploaded a new change for review.
https://gerrit.wikimedia.org/r/158246
Change subject: QA: updated for current behavior
......................................................................
QA: updated for current behavior
This seems very much by design, so I did not file a bug:
GettingStarted suggests editing the current page and offers
"No thanks" as the only options.
Change-Id: Ic353fe692a6d655d3beedc82b09fa939385e0cad
---
M tests/browser/features/modal_on_editable_returnto.feature
M tests/browser/features/step_definitions/modal_on_editable_returnto_steps.rb
M tests/browser/features/support/pages/editable_return_to_page.rb
3 files changed, 0 insertions(+), 6 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/GettingStarted
refs/changes/46/158246/1
diff --git a/tests/browser/features/modal_on_editable_returnto.feature
b/tests/browser/features/modal_on_editable_returnto.feature
index 17927c2..1651134 100644
--- a/tests/browser/features/modal_on_editable_returnto.feature
+++ b/tests/browser/features/modal_on_editable_returnto.feature
@@ -6,5 +6,4 @@
And I have been returned to an editable page
Then I should see a modal call to action
And one action is edit this page
- And one action is edit a suggested page
And one action is no thanks, maybe later
diff --git
a/tests/browser/features/step_definitions/modal_on_editable_returnto_steps.rb
b/tests/browser/features/step_definitions/modal_on_editable_returnto_steps.rb
index c0413bc..2d0d948 100644
---
a/tests/browser/features/step_definitions/modal_on_editable_returnto_steps.rb
+++
b/tests/browser/features/step_definitions/modal_on_editable_returnto_steps.rb
@@ -14,10 +14,6 @@
expect(on(EditableReturnToPage).edit_this_page_element).to be_visible
end
-Then(/^one action is edit a suggested page$/) do
- expect(on(EditableReturnToPage).edit_suggested_page_element).to
be_visible
-end
-
Then(/^one action is no thanks, maybe later$/) do
expect(on(EditableReturnToPage).no_thanks_element).to be_visible
end
diff --git a/tests/browser/features/support/pages/editable_return_to_page.rb
b/tests/browser/features/support/pages/editable_return_to_page.rb
index 28b3538..82778fd 100644
--- a/tests/browser/features/support/pages/editable_return_to_page.rb
+++ b/tests/browser/features/support/pages/editable_return_to_page.rb
@@ -7,6 +7,5 @@
h1(:title, id: "firstHeading")
div(:cta, id: "mw-gettingstarted-cta-editable-main-page")
a(:edit_this_page, id: "mw-gettingstarted-editable-main-edit-page")
- a(:edit_suggested_page, id: "mw-gettingstarted-editable-main-fix-pages")
a(:no_thanks, class: "mw-gettingstarted-cta-leave-link")
end
--
To view, visit https://gerrit.wikimedia.org/r/158246
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic353fe692a6d655d3beedc82b09fa939385e0cad
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/GettingStarted
Gerrit-Branch: master
Gerrit-Owner: Cmcmahon <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
