Legoktm has submitted this change and it was merged.
Change subject: Fix determination of $revId
......................................................................
Fix determination of $revId
Change-Id: I75cb898dcd20db8052688152d55a8f3d63e9e241
---
M MassMessage.hooks.php
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Legoktm: Looks good to me, approved
jenkins-bot: Verified
diff --git a/MassMessage.hooks.php b/MassMessage.hooks.php
index f788938..bb0589b 100644
--- a/MassMessage.hooks.php
+++ b/MassMessage.hooks.php
@@ -162,7 +162,7 @@
$request = $sktemplate->getRequest();
$direction = $request->getVal( 'direction' );
$diff = $request->getVal( 'diff' );
- $oldid = $request->getInt( 'oldid' );
+ $oldid = $request->getInt( 'oldid' ); // Guaranteed to
be an integer, 0 if invalid
if ( $direction === 'next' && $oldid > 0 ) {
$next = $title->getNextRevisionId( $oldid );
$revId = ( $next ) ? $next : $oldid;
@@ -174,7 +174,7 @@
$revId = (int)$diff;
} elseif ( $diff === 'next' && $oldid > 0 ) {
$next = $title->getNextRevisionId(
$oldid );
- $revId = ( $next ) ? $next : $revId;
+ $revId = ( $next ) ? $next : $oldid;
} else { // diff is 'prev' or gibberish
$revId = $oldid;
}
--
To view, visit https://gerrit.wikimedia.org/r/158849
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I75cb898dcd20db8052688152d55a8f3d63e9e241
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/MassMessage
Gerrit-Branch: contenthandler
Gerrit-Owner: Wctaiwan <[email protected]>
Gerrit-Reviewer: Legoktm <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
