jenkins-bot has submitted this change and it was merged.
Change subject: Make ApiQueryMessageGroupTest tests passing with MW master
......................................................................
Make ApiQueryMessageGroupTest tests passing with MW master
Change-Id: Id79af755bd205f1148b7f405c0464ea7a6dc5d72
---
M tests/phpunit/api/ApiQueryMessageGroupsTest.php
1 file changed, 11 insertions(+), 7 deletions(-)
Approvals:
Anomie: Looks good to me, but someone else must approve
Jsahleen: Looks good to me, approved
jenkins-bot: Verified
diff --git a/tests/phpunit/api/ApiQueryMessageGroupsTest.php
b/tests/phpunit/api/ApiQueryMessageGroupsTest.php
index ccb5282..3882d39 100644
--- a/tests/phpunit/api/ApiQueryMessageGroupsTest.php
+++ b/tests/phpunit/api/ApiQueryMessageGroupsTest.php
@@ -52,11 +52,13 @@
'action' => 'query',
'meta' => 'messagegroups',
'mgprop' => 'id|label|class|namespace|exists',
+ // @see
https://gerrit.wikimedia.org/r/#/c/160222/
+ 'continue' => ''
)
);
// Check structure
- $this->assertCount( 1, $data );
+ $this->assertArrayNotHasKey( 'warnings', $data );
$this->assertArrayHasKey( 'query', $data );
$this->assertCount( 1, $data['query'] );
$this->assertArrayHasKey( 'messagegroups', $data['query'] );
@@ -97,13 +99,15 @@
'action' => 'query',
'meta' => 'messagegroups',
'mgprop' =>
'id|label|class|namespace|exists',
- 'mgfilter' => $id
+ 'mgfilter' => $id,
+ // @see
https://gerrit.wikimedia.org/r/#/c/160222/
+ 'continue' => ''
)
);
if ( $id === 'MadeUpGroup' ) {
// Check structure (shouldn't find anything)
- $this->assertCount( 1, $data );
+ $this->assertArrayNotHasKey( 'warnings', $data
);
$this->assertArrayHasKey( 'query', $data );
$this->assertCount( 1, $data['query'] );
$this->assertArrayHasKey( 'messagegroups',
$data['query'] );
@@ -112,7 +116,7 @@
}
// Check structure (filter is unique given these names)
- $this->assertCount( 1, $data );
+ $this->assertArrayNotHasKey( 'warnings', $data );
$this->assertArrayHasKey( 'query', $data );
$this->assertCount( 1, $data['query'] );
$this->assertArrayHasKey( 'messagegroups',
$data['query'] );
@@ -136,11 +140,11 @@
array(
'action' => 'query',
'meta' => 'messagegroups',
- 'mgprop' => 'madeupproperty'
+ 'mgprop' => 'madeupproperty',
+ // @see
https://gerrit.wikimedia.org/r/#/c/160222/
+ 'continue' => ''
)
);
-
- $this->assertCount( 2, $data );
$this->assertArrayHasKey( 'query', $data );
$this->assertCount( 1, $data['query'] );
--
To view, visit https://gerrit.wikimedia.org/r/169362
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id79af755bd205f1148b7f405c0464ea7a6dc5d72
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Translate
Gerrit-Branch: master
Gerrit-Owner: Nikerabbit <[email protected]>
Gerrit-Reviewer: Anomie <[email protected]>
Gerrit-Reviewer: Jsahleen <[email protected]>
Gerrit-Reviewer: Nikerabbit <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
