Dbrant has uploaded a new change for review.
https://gerrit.wikimedia.org/r/170336
Change subject: User paddingTop instead of marginTop to account for ActionBar.
......................................................................
User paddingTop instead of marginTop to account for ActionBar.
On my 2.3 device, marginTop wasn't working, and these fragments were not
offset correctly (topmost content hidden behind the ActionBar).
Change-Id: I0626d6ef520e9712f035e48cbfae7874113f044d
---
M wikipedia/res/layout/fragment_history.xml
M wikipedia/res/layout/fragment_nearby.xml
M wikipedia/res/layout/fragment_saved_pages.xml
3 files changed, 3 insertions(+), 3 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/apps/android/wikipedia
refs/changes/36/170336/1
diff --git a/wikipedia/res/layout/fragment_history.xml
b/wikipedia/res/layout/fragment_history.xml
index d67ff03..65c5759 100644
--- a/wikipedia/res/layout/fragment_history.xml
+++ b/wikipedia/res/layout/fragment_history.xml
@@ -4,7 +4,7 @@
android:layout_width="match_parent"
android:layout_height="match_parent"
android:background="?attr/window_background_color"
- android:layout_marginTop="@dimen/actionBarHeight">
+ android:paddingTop="@dimen/actionBarHeight">
<LinearLayout
android:id="@+id/history_empty_container"
android:orientation="vertical"
diff --git a/wikipedia/res/layout/fragment_nearby.xml
b/wikipedia/res/layout/fragment_nearby.xml
index 65025d8..63bd966 100644
--- a/wikipedia/res/layout/fragment_nearby.xml
+++ b/wikipedia/res/layout/fragment_nearby.xml
@@ -5,7 +5,7 @@
android:layout_width="match_parent"
android:layout_height="match_parent"
android:background="?attr/page_background_color"
- android:layout_marginTop="@dimen/actionBarHeight">
+ android:paddingTop="@dimen/actionBarHeight">
<LinearLayout
android:id="@+id/nearby_empty_container"
diff --git a/wikipedia/res/layout/fragment_saved_pages.xml
b/wikipedia/res/layout/fragment_saved_pages.xml
index 62d3c4d..cd25b05 100644
--- a/wikipedia/res/layout/fragment_saved_pages.xml
+++ b/wikipedia/res/layout/fragment_saved_pages.xml
@@ -4,7 +4,7 @@
android:layout_width="match_parent"
android:layout_height="match_parent"
android:background="?attr/window_background_color"
- android:layout_marginTop="@dimen/actionBarHeight">
+ android:paddingTop="@dimen/actionBarHeight">
<LinearLayout
android:id="@+id/saved_pages_empty_container"
android:orientation="vertical"
--
To view, visit https://gerrit.wikimedia.org/r/170336
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0626d6ef520e9712f035e48cbfae7874113f044d
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Dbrant <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
