01tonythomas has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/170337

Change subject: Remove unused variable $bouncedUserId
......................................................................

Remove unused variable $bouncedUserId

The extension saves only the failing user email id, failure reason and
bounce timestamp

Change-Id: I502e288cdf3993d18e3e94d56e0106523848a93e
---
M includes/ProcessBounceEmails.php
1 file changed, 2 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/BounceHandler 
refs/changes/37/170337/1

diff --git a/includes/ProcessBounceEmails.php b/includes/ProcessBounceEmails.php
index 37437d6..a554631 100644
--- a/includes/ProcessBounceEmails.php
+++ b/includes/ProcessBounceEmails.php
@@ -50,12 +50,11 @@
 
                // Get original failed user email and wiki details
                $failedUser = $this->getUserDetails( $to );
-               if( is_array( $failedUser ) && isset( $failedUser['wikiId'] ) 
&& isset( $failedUser[ 'rawUserId'] )
-               && isset( $failedUser['rawEmail'] ) && isset( $failedUser[ 
'bounceTime' ] ) ) {
+               if( is_array( $failedUser ) && isset( $failedUser['wikiId'] ) 
&& isset( $failedUser['rawEmail'] )
+               && isset( $failedUser[ 'bounceTime' ] ) ) {
                        $wikiId = $failedUser['wikiId'];
                        $originalEmail = $failedUser['rawEmail'];
                        $bounceTimestamp= $failedUser['bounceTime'];
-                       $bouncedUserId = $failedUser['rawUserId'];
                        $dbw = wfGetDB( DB_MASTER, array(), $wikiId );
 
                        $rowData = array(

-- 
To view, visit https://gerrit.wikimedia.org/r/170337
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I502e288cdf3993d18e3e94d56e0106523848a93e
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/BounceHandler
Gerrit-Branch: master
Gerrit-Owner: 01tonythomas <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to