Bmansurov has uploaded a new change for review.
https://gerrit.wikimedia.org/r/172353
Change subject: Instrument search, hamburger and notification clicks
......................................................................
Instrument search, hamburger and notification clicks
Change-Id: Id78ac96d9940b179f1bcd5d755fa25e86c33cff3
---
M javascripts/mainmenu.js
M javascripts/modules/notifications/notifications.js
M javascripts/modules/search/search.js
3 files changed, 8 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend
refs/changes/53/172353/1
diff --git a/javascripts/mainmenu.js b/javascripts/mainmenu.js
index 25399c2..945afbc 100644
--- a/javascripts/mainmenu.js
+++ b/javascripts/mainmenu.js
@@ -1,4 +1,5 @@
( function ( M, $ ) {
+ var schema = M.require( 'loggingSchemas/MobileWebClickTracking' );
function isOpen() {
return $( 'body' ).hasClass( 'navigation-enabled' );
@@ -29,6 +30,8 @@
// (when JS is on, this input should not be used for typing
anyway)
$( '#searchInput' ).prop( 'readonly', true );
$( '#mw-mf-main-menu-button' ).on( 'click', function ( ev ) {
+ schema.log( 'hamburger' );
+
if ( isOpen() ) {
closeNavigationDrawers();
} else {
diff --git a/javascripts/modules/notifications/notifications.js
b/javascripts/modules/notifications/notifications.js
index 19832c3..d006100 100644
--- a/javascripts/modules/notifications/notifications.js
+++ b/javascripts/modules/notifications/notifications.js
@@ -3,7 +3,7 @@
* with the Toast notifications defined by common/toast.js.
*/
( function ( M, $ ) {
- var
+ var schema = M.require( 'loggingSchemas/MobileWebClickTracking' ),
mainmenu = M.require( 'mainmenu' ),
$btn = $( '#secondary-button.user-button' );
@@ -29,6 +29,7 @@
// than linking to Special:Notifications.
$( function () {
$btn.on( 'click', function () {
+ schema.log( 'notifications' );
M.router.navigate( '#/notifications' );
// Important that we also prevent propagation to avoid
interference with events that may be
// binded on #mw-mf-page-center that close overlay
diff --git a/javascripts/modules/search/search.js
b/javascripts/modules/search/search.js
index 2db61f7..6338162 100644
--- a/javascripts/modules/search/search.js
+++ b/javascripts/modules/search/search.js
@@ -1,6 +1,7 @@
( function ( M, $ ) {
- var SearchOverlay = M.require( 'modules/search/SearchOverlay' );
+ var SearchOverlay = M.require( 'modules/search/SearchOverlay' ),
+ schema = M.require( 'loggingSchemas/MobileWebClickTracking' );
//
// don't use focus event
(https://bugzilla.wikimedia.org/show_bug.cgi?id=47499)
@@ -9,6 +10,7 @@
// from user context event, so using it in route callback won't work
//
http://stackoverflow.com/questions/6837543/show-virtual-keyboard-on-mobile-phones-in-javascript
$( '#searchInput' ).on( 'click', function () {
+ schema.log( 'search' );
new SearchOverlay( { searchTerm: $( this ).val() } ).show();
M.router.navigate( '/search' );
} );
--
To view, visit https://gerrit.wikimedia.org/r/172353
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id78ac96d9940b179f1bcd5d755fa25e86c33cff3
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Bmansurov <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
