jenkins-bot has submitted this change and it was merged.
Change subject: Instrument search, hamburger and notification clicks
......................................................................
Instrument search, hamburger and notification clicks
Change-Id: Id78ac96d9940b179f1bcd5d755fa25e86c33cff3
---
M includes/Resources.php
M javascripts/loggingSchemas/MobileWebClickTracking.js
M javascripts/modules/notifications/notifications.js
M javascripts/modules/search/search.js
4 files changed, 21 insertions(+), 12 deletions(-)
Approvals:
Phuedx: Looks good to me, approved
jenkins-bot: Verified
diff --git a/includes/Resources.php b/includes/Resources.php
index 272be02..04121ab 100644
--- a/includes/Resources.php
+++ b/includes/Resources.php
@@ -489,6 +489,7 @@
'mobile.pagelist.scripts',
'mobile.overlays',
'mobile.templates',
+ 'mobile.loggingSchemas',
),
'styles' => array(
'less/modules/search/SearchOverlay.less',
diff --git a/javascripts/loggingSchemas/MobileWebClickTracking.js
b/javascripts/loggingSchemas/MobileWebClickTracking.js
index 23c977d..5a8e6f7 100644
--- a/javascripts/loggingSchemas/MobileWebClickTracking.js
+++ b/javascripts/loggingSchemas/MobileWebClickTracking.js
@@ -52,16 +52,20 @@
return $( this ).children().length === 0;
} );
- hijackLink( '#mw-mf-page-left .icon-home', 'hamburger-home' );
- hijackLink( '#mw-mf-page-left .icon-random', 'hamburger-random'
);
- hijackLink( '#mw-mf-page-left .icon-nearby', 'hamburger-nearby'
);
- hijackLink( '#mw-mf-page-left .icon-watchlist',
'hamburger-watchlist' );
- hijackLink( '#mw-mf-page-left .icon-settings',
'hamburger-settings' );
- hijackLink( '#mw-mf-page-left .icon-uploads',
'hamburger-uploads' );
- hijackLink( '#mw-mf-page-left .icon-profile',
'hamburger-profile' );
- hijackLink( '#mw-mf-page-left .icon-anon', 'hamburger-login' );
- hijackLink( '#mw-mf-page-left .icon-secondary-logout',
'hamburger-logout' );
- hijackLink( $( '#mw-mf-last-modified a span' ).parent(),
'lastmodified-history' );
- hijackLink( $profileLink, 'lastmodified-profile' );
+ $( '#mw-mf-main-menu-button' ).on( 'click', function ()
{
+ log( 'hamburger' );
+ } );
+
+ hijackLink( '#mw-mf-page-left .icon-home',
'hamburger-home' );
+ hijackLink( '#mw-mf-page-left .icon-random',
'hamburger-random' );
+ hijackLink( '#mw-mf-page-left .icon-nearby',
'hamburger-nearby' );
+ hijackLink( '#mw-mf-page-left .icon-watchlist',
'hamburger-watchlist' );
+ hijackLink( '#mw-mf-page-left .icon-settings',
'hamburger-settings' );
+ hijackLink( '#mw-mf-page-left .icon-uploads',
'hamburger-uploads' );
+ hijackLink( '#mw-mf-page-left .icon-profile',
'hamburger-profile' );
+ hijackLink( '#mw-mf-page-left .icon-anon',
'hamburger-login' );
+ hijackLink( '#mw-mf-page-left .icon-secondary-logout',
'hamburger-logout' );
+ hijackLink( $( '#mw-mf-last-modified a span'
).parent(), 'lastmodified-history' );
+ hijackLink( $profileLink, 'lastmodified-profile' );
} );
} )( mw.mobileFrontend, jQuery );
diff --git a/javascripts/modules/notifications/notifications.js
b/javascripts/modules/notifications/notifications.js
index 98b753f..c4bdf59 100644
--- a/javascripts/modules/notifications/notifications.js
+++ b/javascripts/modules/notifications/notifications.js
@@ -4,6 +4,7 @@
*/
( function ( M, $ ) {
var Icon = M.require( 'Icon' ),
+ schema = M.require( 'loggingSchemas/MobileWebClickTracking' ),
mainmenu = M.require( 'mainmenu' ),
$btn = $( '#secondary-button.user-button' );
@@ -34,6 +35,7 @@
// than linking to Special:Notifications.
$( function () {
$btn.on( 'click', function () {
+ schema.log( 'notifications' );
M.router.navigate( '#/notifications' );
// Important that we also prevent propagation to avoid
interference with events that may be
// binded on #mw-mf-page-center that close overlay
diff --git a/javascripts/modules/search/search.js
b/javascripts/modules/search/search.js
index 80ef11b..fc2b6fe 100644
--- a/javascripts/modules/search/search.js
+++ b/javascripts/modules/search/search.js
@@ -1,6 +1,7 @@
( function ( M, $ ) {
- var SearchOverlay = M.require( 'modules/search/SearchOverlay' );
+ var SearchOverlay = M.require( 'modules/search/SearchOverlay' ),
+ schema = M.require( 'loggingSchemas/MobileWebClickTracking' );
//
// don't use focus event
(https://bugzilla.wikimedia.org/show_bug.cgi?id=47499)
@@ -9,6 +10,7 @@
// from user context event, so using it in route callback won't work
//
http://stackoverflow.com/questions/6837543/show-virtual-keyboard-on-mobile-phones-in-javascript
$( '#searchInput' ).on( 'click', function () {
+ schema.log( 'search' );
new SearchOverlay( { searchTerm: $( this ).val() } ).show();
M.router.navigate( '/search' );
} );
--
To view, visit https://gerrit.wikimedia.org/r/172353
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id78ac96d9940b179f1bcd5d755fa25e86c33cff3
Gerrit-PatchSet: 4
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Bmansurov <[email protected]>
Gerrit-Reviewer: Awjrichards <[email protected]>
Gerrit-Reviewer: Jdlrobson <[email protected]>
Gerrit-Reviewer: Phuedx <[email protected]>
Gerrit-Reviewer: Robmoen <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
