Adrian Lang has uploaded a new change for review.
https://gerrit.wikimedia.org/r/172725
Change subject: Use Xml::encodeJsCall
......................................................................
Use Xml::encodeJsCall
Change-Id: Idf4de94d18d13e58b18f0d1cb1215a8f5cb26074
---
M lib/includes/modules/SitesModule.php
1 file changed, 3 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase
refs/changes/25/172725/1
diff --git a/lib/includes/modules/SitesModule.php
b/lib/includes/modules/SitesModule.php
index b1a8ce6..6f0b549 100644
--- a/lib/includes/modules/SitesModule.php
+++ b/lib/includes/modules/SitesModule.php
@@ -6,6 +6,7 @@
use ResourceLoaderModule;
use Site;
use SiteSQLStore;
+use Xml;
/**
*
@@ -102,7 +103,7 @@
)
);
- //TODO: figure out which name ist best
+ //TODO: figure out which name is best
//$localIds = $site->getLocalIds();
//$name = empty( $localIds['equivalent'] ) ?
$site->getGlobalId() : $localIds['equivalent'][0];
@@ -117,7 +118,7 @@
);
}
- return 'mediaWiki.config.set( "wbSiteDetails", ' .
\FormatJson::encode( $sites ) . ' );';
+ return Xml::encodeJsCall( 'mediaWiki.config.set', array(
'wbSiteDetails', $sites ) );
}
/**
--
To view, visit https://gerrit.wikimedia.org/r/172725
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Idf4de94d18d13e58b18f0d1cb1215a8f5cb26074
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Adrian Lang <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
