Zfilipin has uploaded a new change for review.
https://gerrit.wikimedia.org/r/172726
Change subject: Fixed RuboCop Style/AsciiComments offense
......................................................................
Fixed RuboCop Style/AsciiComments offense
Bug: 72841
Change-Id: I0f4cc4e8ab2ccb3b6b2d674e7912dd16ad411726
---
M .rubocop_todo.yml
M bin/doccomparer.rb
2 files changed, 1 insertion(+), 5 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/oojs/ui refs/changes/26/172726/1
diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml
index e7c99d3..e59491c 100644
--- a/.rubocop_todo.yml
+++ b/.rubocop_todo.yml
@@ -32,10 +32,6 @@
Metrics/PerceivedComplexity:
Max: 48
-# Offense count: 1
-Style/AsciiComments:
- Enabled: false
-
# Offense count: 8
# Cop supports --auto-correct.
Style/Blocks:
diff --git a/bin/doccomparer.rb b/bin/doccomparer.rb
index 6f9ec69..6ce3591 100644
--- a/bin/doccomparer.rb
+++ b/bin/doccomparer.rb
@@ -1,7 +1,7 @@
require 'pp'
require_relative 'docparser'
-# convert [ {name: 'foo'}, … ] to { foo: {name: 'foo'}, … }
+# convert [ {name: 'foo'}, ... ] to { foo: {name: 'foo'}, ... }
def reindex arg
if arg.is_a?(Array) && arg.all?{|v| v.is_a? Hash }
Hash[ arg.map{|v| [ v[:name], reindex(v) ] } ]
--
To view, visit https://gerrit.wikimedia.org/r/172726
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0f4cc4e8ab2ccb3b6b2d674e7912dd16ad411726
Gerrit-PatchSet: 1
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: Zfilipin <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
