Zfilipin has uploaded a new change for review.
https://gerrit.wikimedia.org/r/172739
Change subject: Fixed RuboCop Style/NilComparison offense
......................................................................
Fixed RuboCop Style/NilComparison offense
Bug: 72841
Change-Id: I2b16ab1de6a145ec4e6c66932faaeb519121fa08
---
M .rubocop_todo.yml
M bin/doccomparer.rb
2 files changed, 2 insertions(+), 7 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/oojs/ui refs/changes/39/172739/1
diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml
index e36d883..fb24f26 100644
--- a/.rubocop_todo.yml
+++ b/.rubocop_todo.yml
@@ -76,11 +76,6 @@
Style/Next:
Enabled: false
-# Offense count: 2
-# Cop supports --auto-correct.
-Style/NilComparison:
- Enabled: false
-
# Offense count: 6
# Cop supports --auto-correct.
# Configuration parameters: PreferredDelimiters.
diff --git a/bin/doccomparer.rb b/bin/doccomparer.rb
index 8bd6e78..cf65031 100644
--- a/bin/doccomparer.rb
+++ b/bin/doccomparer.rb
@@ -118,9 +118,9 @@
else
if a_val == b_val
"#{key}: match" if $VERBOSE
- elsif a_val == nil
+ elsif a_val.nil?
"#{key}: #{a_name} missing"
- elsif b_val == nil
+ elsif b_val.nil?
"#{key}: #{b_name} missing"
else
"#{key}: MISMATCH\n #{a_name}:
#{a_val.inspect}\n #{b_name}: #{b_val.inspect}"
--
To view, visit https://gerrit.wikimedia.org/r/172739
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2b16ab1de6a145ec4e6c66932faaeb519121fa08
Gerrit-PatchSet: 1
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: Zfilipin <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
