Gerrit Patch Uploader has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/172814

Change subject: SpecialRecentchanges: Repair recentchangestext in content 
language
......................................................................

SpecialRecentchanges: Repair recentchangestext in content language

* Use getHtmlCode() instead of getCode() to generate a BCP 47 conform
  HTML lang attribute.
* Use <div> instead of <p> because the <p> gets rendered as

<p lang="en" dir="ltr"></p>
Text
<p></p>

and the <div> gets rendered as

<div lang="en" dir="ltr">
Text
</div>

Change-Id: I62ce26ba550fb25bc2e770186cea3435374bb4e6
---
M includes/specials/SpecialRecentchanges.php
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/14/172814/1

diff --git a/includes/specials/SpecialRecentchanges.php 
b/includes/specials/SpecialRecentchanges.php
index e6d8f1c..3016d20 100644
--- a/includes/specials/SpecialRecentchanges.php
+++ b/includes/specials/SpecialRecentchanges.php
@@ -440,8 +440,8 @@
                $message = $this->msg( 'recentchangestext' 
)->inContentLanguage();
                if ( !$message->isDisabled() ) {
                        $this->getOutput()->addWikiText(
-                               Html::rawElement( 'p',
-                                       array( 'lang' => 
$wgContLang->getCode(), 'dir' => $wgContLang->getDir() ),
+                               Html::rawElement( 'div',
+                                       array( 'lang' => 
$wgContLang->getHtmlCode(), 'dir' => $wgContLang->getDir() ),
                                        "\n" . $message->plain() . "\n"
                                ),
                                /* $lineStart */ false,

-- 
To view, visit https://gerrit.wikimedia.org/r/172814
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I62ce26ba550fb25bc2e770186cea3435374bb4e6
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Gerrit Patch Uploader <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to