jenkins-bot has submitted this change and it was merged.
Change subject: SpecialRecentchanges: Repair recentchangestext in content
language
......................................................................
SpecialRecentchanges: Repair recentchangestext in content language
* Use getHtmlCode() instead of getCode() to generate a BCP 47 conform
HTML lang attribute.
* Use <div> instead of <p> because the <p> gets rendered as
<p lang="en" dir="ltr"></p>
<p>Text</p>
<p></p>
and the <div> gets rendered as
<div lang="en" dir="ltr">
<p>Text</p>
</div>
* Set $lineStart = true
Change-Id: I62ce26ba550fb25bc2e770186cea3435374bb4e6
---
M includes/specials/SpecialRecentchanges.php
1 file changed, 3 insertions(+), 3 deletions(-)
Approvals:
Nikerabbit: Looks good to me, approved
jenkins-bot: Verified
diff --git a/includes/specials/SpecialRecentchanges.php
b/includes/specials/SpecialRecentchanges.php
index e6d8f1c..58b51b3 100644
--- a/includes/specials/SpecialRecentchanges.php
+++ b/includes/specials/SpecialRecentchanges.php
@@ -440,11 +440,11 @@
$message = $this->msg( 'recentchangestext'
)->inContentLanguage();
if ( !$message->isDisabled() ) {
$this->getOutput()->addWikiText(
- Html::rawElement( 'p',
- array( 'lang' =>
$wgContLang->getCode(), 'dir' => $wgContLang->getDir() ),
+ Html::rawElement( 'div',
+ array( 'lang' =>
$wgContLang->getHtmlCode(), 'dir' => $wgContLang->getDir() ),
"\n" . $message->plain() . "\n"
),
- /* $lineStart */ false,
+ /* $lineStart */ true,
/* $interface */ false
);
}
--
To view, visit https://gerrit.wikimedia.org/r/172814
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I62ce26ba550fb25bc2e770186cea3435374bb4e6
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Gerrit Patch Uploader <[email protected]>
Gerrit-Reviewer: Fomafix
Gerrit-Reviewer: Gerrit Patch Uploader <[email protected]>
Gerrit-Reviewer: Nemo bis <[email protected]>
Gerrit-Reviewer: Nikerabbit <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
