Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/173214
Change subject: Hygiene: Remove dead code paths
......................................................................
Hygiene: Remove dead code paths
* Last modified is always at top. No need for beta specific code.
* wgMFUserGender is not used anywhere
* Alpha overrides the function but isn't doing anything different from
the one in stable
Change-Id: I553cee09b49814529efeaf1f3595891805634853
---
M includes/skins/SkinMinervaAlpha.php
M includes/skins/SkinMinervaBeta.php
2 files changed, 0 insertions(+), 51 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend
refs/changes/14/173214/1
diff --git a/includes/skins/SkinMinervaAlpha.php
b/includes/skins/SkinMinervaAlpha.php
index db3d1d2..16da184 100644
--- a/includes/skins/SkinMinervaAlpha.php
+++ b/includes/skins/SkinMinervaAlpha.php
@@ -34,29 +34,6 @@
}
/**
- * Creates element relating to secondary button
- * @param string $title Title attribute value of secondary button
- * @param string $url of secondary button
- * @param string $spanLabel text of span associated with secondary
button.
- * @param string $spanClass the class of the secondary button
- * @return string html relating to button
- */
- protected function createSecondaryButton( $title, $url, $spanLabel,
$spanClass ) {
- return Html::element( 'a', array(
- 'title' => $title,
- 'href' => $url,
- 'class' => MobileUI::iconClass(
'notifications', 'element',
- 'user-button main-header-button
icon-32px' ),
- 'id' => 'secondary-button',
- ) ) .
- Html::element(
- 'span',
- array( 'class' => $spanClass ),
- $spanLabel
- );
- }
-
- /**
* Get various skin specific configuration.
* @return array
*/
diff --git a/includes/skins/SkinMinervaBeta.php
b/includes/skins/SkinMinervaBeta.php
index 51072a1..212af2c 100644
--- a/includes/skins/SkinMinervaBeta.php
+++ b/includes/skins/SkinMinervaBeta.php
@@ -28,34 +28,6 @@
}
/**
- * initialize various variables and generate the template
- * @return QuickTemplate
- */
- protected function prepareQuickTemplate() {
- $tpl = parent::prepareQuickTemplate();
- // Move last modified link to top as long as it is not the main
page
- $tpl->set( '_lastModifiedAbove',
!$this->getTitle()->isMainPage() );
- return $tpl;
- }
-
- /**
- * Get various skin specific configuration.
- * @return array
- */
- public function getSkinConfigVariables() {
- $vars = parent::getSkinConfigVariables();
- // Kill this when we fix the functionality in PageApi.js
- $user = $this->getUser();
- if ( $user->isLoggedIn() ) {
- $vars['wgMFUserGender'] = $this->getUser()->getOption(
'gender' );
- } else {
- $vars['wgMFUserGender'] = 'unknown';
- }
-
- return $vars;
- }
-
- /**
* Returns the javascript modules to load.
* @return array
*/
--
To view, visit https://gerrit.wikimedia.org/r/173214
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I553cee09b49814529efeaf1f3595891805634853
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
