jenkins-bot has submitted this change and it was merged.
Change subject: Hygiene: Remove dead code paths
......................................................................
Hygiene: Remove dead code paths
* Last modified is always at top. No need for beta specific code.
* wgMFUserGender is not used anywhere
* Update alpha function so it's clearer.
Change-Id: I553cee09b49814529efeaf1f3595891805634853
---
M includes/skins/SkinMinervaAlpha.php
M includes/skins/SkinMinervaBeta.php
2 files changed, 1 insertion(+), 28 deletions(-)
Approvals:
Bmansurov: Looks good to me, approved
jenkins-bot: Verified
diff --git a/includes/skins/SkinMinervaAlpha.php
b/includes/skins/SkinMinervaAlpha.php
index db3d1d2..aa3c227 100644
--- a/includes/skins/SkinMinervaAlpha.php
+++ b/includes/skins/SkinMinervaAlpha.php
@@ -35,6 +35,7 @@
/**
* Creates element relating to secondary button
+ * Unlike method in stable adds span outside the link element.
* @param string $title Title attribute value of secondary button
* @param string $url of secondary button
* @param string $spanLabel text of span associated with secondary
button.
diff --git a/includes/skins/SkinMinervaBeta.php
b/includes/skins/SkinMinervaBeta.php
index 51072a1..212af2c 100644
--- a/includes/skins/SkinMinervaBeta.php
+++ b/includes/skins/SkinMinervaBeta.php
@@ -28,34 +28,6 @@
}
/**
- * initialize various variables and generate the template
- * @return QuickTemplate
- */
- protected function prepareQuickTemplate() {
- $tpl = parent::prepareQuickTemplate();
- // Move last modified link to top as long as it is not the main
page
- $tpl->set( '_lastModifiedAbove',
!$this->getTitle()->isMainPage() );
- return $tpl;
- }
-
- /**
- * Get various skin specific configuration.
- * @return array
- */
- public function getSkinConfigVariables() {
- $vars = parent::getSkinConfigVariables();
- // Kill this when we fix the functionality in PageApi.js
- $user = $this->getUser();
- if ( $user->isLoggedIn() ) {
- $vars['wgMFUserGender'] = $this->getUser()->getOption(
'gender' );
- } else {
- $vars['wgMFUserGender'] = 'unknown';
- }
-
- return $vars;
- }
-
- /**
* Returns the javascript modules to load.
* @return array
*/
--
To view, visit https://gerrit.wikimedia.org/r/173214
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I553cee09b49814529efeaf1f3595891805634853
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson <[email protected]>
Gerrit-Reviewer: Awjrichards <[email protected]>
Gerrit-Reviewer: Bmansurov <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
